Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy keypad and replace it with MobileKeypad #825

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Remove the legacy keypad and replace it with MobileKeypad #825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8fa167
Remove the legacy keypad and replace it with MobileKeypad
benchristel Nov 29, 2023
1742a8f
Get keypadActive and setKeypadActive in wrapper component
benchristel Nov 29, 2023
a343751
Add changeset
benchristel Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/math-input/src/components/__tests__/integration.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import React, {useState} from "react";

import {KeypadType} from "../../enums";
import MathInput from "../input/math-input";
import {MobileKeypad} from "../keypad";
import {KeypadContext, StatefulKeypadContextProvider} from "../keypad-context";
import KeypadSwitch from "../keypad-switch";

import type {KeypadConfiguration} from "../../types";

Expand Down Expand Up @@ -58,13 +58,14 @@ function InputWithContext({keypadConfiguration}) {
function KeypadWithContext() {
return (
<KeypadContext.Consumer>
{({setKeypadElement}) => {
{({setKeypadElement, keypadActive, setKeypadActive}) => {
return (
<KeypadSwitch
<MobileKeypad
onElementMounted={setKeypadElement}
onDismiss={() => {}}
onAnalyticsEvent={async () => {}}
useV2Keypad
keypadActive={keypadActive}
setKeypadActive={setKeypadActive}
/>
);
}}
Expand Down
Loading
Loading