Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll v2 Keypad Onto Desktop Web (#645)" to unblock release while making focus changes #675

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

nedredmond
Copy link
Contributor

This reverts commit e036092.

On August 17, a few conversations were had that led to the following plan of attack for Keypad focus handling:
https://khanacademy.slack.com/archives/C8XGW76FQ/p1692301859002839?thread_ts=1692120760.613379&cid=C8XGW76FQ

While we make the necessary changes to Keypad and then to the expression widget, reverting this to keep Perseus releasable.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: 8a52f64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team August 17, 2023 20:47
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Aug 17, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/five-meals-wink.md, packages/perseus/src/components/math-input.tsx, packages/perseus/src/styles/perseus-renderer.less, packages/perseus/src/widgets/expression.tsx, packages/perseus-editor/src/widgets/expression-editor.tsx, packages/perseus-editor/src/widgets/interaction-editor.tsx, packages/perseus/src/components/__stories__/math-input.stories.tsx, packages/perseus/src/components/__tests__/math-input.test.tsx, packages/perseus/src/styles/widgets/expression.less, packages/perseus/src/widgets/__tests__/expression.test.ts, packages/perseus-editor/src/widgets/interaction/constraint-editor.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

Size Change: -2.06 kB (0%)

Total Size: 846 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 268 kB +23 B (0%)
packages/perseus/dist/es/index.js 396 kB -2.08 kB (-1%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 102 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (e25e659) and published it to npm. You
can install it using the tag PR675.

Example:

yarn add @khanacademy/perseus@PR675

@nedredmond nedredmond merged commit faadbf8 into main Aug 17, 2023
@nedredmond nedredmond deleted the ned/revert-for-focus-refactor branch August 17, 2023 21:06
@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2023

Coverage Status

coverage: 69.352% (+0.03%) from 69.327% when pulling 8a52f64 on ned/revert-for-focus-refactor into b93f9f7 on main.

nedredmond added a commit that referenced this pull request Sep 7, 2023
…lease while making focus changes (#675)"

This reverts commit faadbf8.
nedredmond added a commit that referenced this pull request Sep 26, 2023
…lease while making focus changes (#675)"

This reverts commit faadbf8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants