-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Roll v2 Keypad Onto Desktop Web (#645)" to unblock release while making focus changes #675
Conversation
This reverts commit e036092.
🦋 Changeset detectedLatest commit: 8a52f64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: -2.06 kB (0%) Total Size: 846 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (e25e659) and published it to npm. You Example: yarn add @khanacademy/perseus@PR675 |
This reverts commit e036092.
On August 17, a few conversations were had that led to the following plan of attack for Keypad focus handling:
https://khanacademy.slack.com/archives/C8XGW76FQ/p1692301859002839?thread_ts=1692120760.613379&cid=C8XGW76FQ
While we make the necessary changes to Keypad and then to the expression widget, reverting this to keep Perseus releasable.