Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all alphabet icons #669

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add all alphabet icons #669

merged 2 commits into from
Aug 15, 2023

Conversation

nedredmond
Copy link
Contributor

@nedredmond nedredmond commented Aug 15, 2023

Add all icons for latin alphabet inputs to keypad
LC-1143
Screenshot 2023-08-15 at 2 59 14 PM

@khan-actions-bot khan-actions-bot requested a review from a team August 15, 2023 19:22
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/rich-spies-design.md, packages/math-input/src/components/keypad/button-assets.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

Size Change: +22.4 kB (+3%)

Total Size: 846 kB

Filename Size Change
packages/math-input/dist/es/index.js 102 kB +22.4 kB (+28%) 🚨
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 396 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (9c50d3a) and published it to npm. You
can install it using the tag PR669.

Example:

yarn add @khanacademy/perseus@PR669

@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2023

Coverage Status

coverage: 69.331% (-0.09%) from 69.425% when pulling dfee9e9 on ned/LC-1143 into afb14cf on main.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: dfee9e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@khanacademy/math-input Patch
@khanacademy/perseus Patch
@khanacademy/perseus-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: These letters all look to use a 44x44 viewbox... other entries use 40x40. Is this ok that we have different sizes?

@nedredmond
Copy link
Contributor Author

question: These letters all look to use a 44x44 viewbox... other entries use 40x40. Is this ok that we have different sizes?

@jeremywiebe yeah it's okay, it's scaled to itself. There is absolutely no visual difference between the two.

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeremy, you can't stop me from approving!

This is exciting!

@nedredmond nedredmond merged commit 196d2a3 into main Aug 15, 2023
@nedredmond nedredmond deleted the ned/LC-1143 branch August 15, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants