-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all alphabet icons #669
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +22.4 kB (+3%) Total Size: 846 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (9c50d3a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR669 |
🦋 Changeset detectedLatest commit: dfee9e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: These letters all look to use a 44x44 viewbox... other entries use 40x40. Is this ok that we have different sizes?
@jeremywiebe yeah it's okay, it's scaled to itself. There is absolutely no visual difference between the two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeremy, you can't stop me from approving!
This is exciting!
Add all icons for latin alphabet inputs to keypad
LC-1143