[Numeric Input] - BUGFIX - Adjust color contrast for tooltip text #1966
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f36f5ef) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1966If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1966 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
| @@ -544,7 +544,7 @@ | |||
|
|
|||
| .perseus-formats-tooltip { | |||
| background: #fff; | |||
| color: #777; | |||
| color: #717378; | |||
There was a problem hiding this comment.
Is this a WB color? Even though we're in a .less file, could you use (or define and use) a variable from variables.less?
There was a problem hiding this comment.
Yes it is. I've moved that color to variables.less.
|
I trust this works perfectly, but for sake of PR completion and posterity, could you put a before and after screenshot here @mark-fitzgerald? |
Added. |
mark-fitzgerald
deleted the
bugfix/adjust-color-contrast-for-numeric-input-tooltip
branch
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1966](#1966) [`e22a931d9`](e22a931) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Numeric Input] - BUGFIX - Adjust color contrast of tooltip text ## @khanacademy/[email protected] ### Patch Changes - [#1976](#1976) [`2ad163b5e`](2ad163b) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figures Aria] Update the auto-generated text to spell out commas - Updated dependencies \[[`e22a931d9`](e22a931)]: - @khanacademy/[email protected]
Summary:
The text in the numeric input tooltip was slightly out of spec for accessibility. This change ensures that the text has a minimum 4.5:1 contrast ratio.
Test plan:
Affected UI:
Before
After