Remove deprecated/unused support for examples in Renderer (keeping for numeric-input though) #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r numeric-input though)
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5e29f46) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1961If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1961 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
jeremywiebe
commented
Dec 6, 2024
| @@ -123,8 +123,11 @@ export class NumericInput | |||
| isFocused: false, | |||
| }; | |||
|
|
|||
| // TODO(Nicole, Jeremy): This is maybe never used and should be removed | |||
There was a problem hiding this comment.
This is used, but only internal to the widget.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
approved these changes
Dec 6, 2024
Merged
jeremywiebe
pushed a commit
that referenced
this pull request
Dec 6, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1962](#1962) [`435280ac4`](435280a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Move scoring utility functions out of `Util` object into their own file and only export externally used function (`keScoreFromPerseusScore`) - [#1961](#1961) [`d93e3ecde`](d93e3ec) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove deprecated/unused `examples()` function from `Renderer` ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`435280ac4`](435280a), [`d93e3ecde`](d93e3ec)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on SSS, I came across the
examples()function on theRendererthat was causing me issues (with threading client-side validation in).I checked and it is no longer used anywhere. Note that the
input-numberandnumeric-inputuse their localexamples()functions still to pass a set of examples to theInputWithExamplescomponent, which we're keeping.Implemented in D2749
Issue: LEMS-2561
Test plan:
yarn testyarn typecheckChecked in host webapp and the function is not used.