Version Packages #1944
Merged
Version Packages #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
github-actions
bot
force-pushed
the
changeset-release/main
branch
15 times, most recently
from
315d673 to
ec1742b
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
ec1742b to
cb37797
Compare
mark-fitzgerald
approved these changes
Dec 5, 2024
jeremywiebe
added a commit
that referenced
this pull request
Dec 5, 2024
This reverts commit 5963ea1.
jeremywiebe
added a commit
that referenced
this pull request
Dec 5, 2024
## Summary: The last release failed because the `yarn.lock` file was changed when `yarn install` ran (See #1957). This PR reverses (`git revert 5963ea1`) the release commit so that we can get a new Version Packages PR and land it (and trigger a new release). <img width="932" alt="image" src="https://github.com/user-attachments/assets/81227009-bb4f-4638-9b0b-258e97879c8b"> PR #1957 must be landed after this PR, but _before_ we do a release. Issue: "none" ## Test plan: Author: jeremywiebe Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ❌ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ gerald, ❌ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1958
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@khanacademy/[email protected]
Minor Changes
#1901
051c50cf7Thanks @Myranae! - Introduces a validation function for the number line widget (extracted from the scoring function).#1936
d05272661Thanks @jeremywiebe! - Changes the PerseusWidgetsMap to be extensible so that widgets can be registered outside of Perseus and still have full type safety.#1832
e3062b3c8Thanks @mark-fitzgerald! - [Numeric Input] - Update the UI to match Expression widgetPatch Changes
#1937
3cdabf1a3Thanks @jeremywiebe! - TypeScript fixes#1948
e21a3a39bThanks @jeremywiebe! - Refactor internally used object mapping utilities to use ES6 exports#1938
5e8d8468bThanks @jeremywiebe! - Type fixes#1942
1d2b4e7bfThanks @SonicScrewdriver! - Ensure that zoomed-in images retain alt text#1861
763a4ba38Thanks @mark-fitzgerald! - [Numeric Input] - Show format options as a list#1947
b8926e38aThanks @jeremywiebe! - Minor refactoring of ServerItemRenderer's componentDidUpdate to reduce duplication#1946
f35512786Thanks @jeremywiebe! - Refactor scoring forgroupwidget to follow the same pattern as all other widgets#1891
ef819ea95Thanks @mark-fitzgerald! - [Numeric Input] - Associate format options tooltip content with input field for assistive technologies#1945
e69ca3146Thanks @nishasy! - Add global styles to reflect prod styling#1923
be8c06c75Thanks @benchristel! - Internal: convert backgroundImage dimensions to numbers during parsing.#1934
129adebefThanks @jeremywiebe! - Improve comments on some Perseus types#1924
2d89ef87dThanks @benchristel! - Internal: add and pass regression tests for PerseusItem parser's handling of legacy data@khanacademy/[email protected]
Patch Changes
#1938
5e8d8468bThanks @jeremywiebe! - Type fixes#1937
3cdabf1a3Thanks @jeremywiebe! - Ensure links opening to style guide (Google Docs) setrel="noreferrer"#1946
f35512786Thanks @jeremywiebe! - Remove debugging call in GraphSettings componentUpdated dependencies [
3cdabf1a3,e21a3a39b,5e8d8468b,1d2b4e7bf,763a4ba38,b8926e38a,f35512786,ef819ea95,e69ca3146,be8c06c75,051c50cf7,129adebef,d05272661,2d89ef87d,e3062b3c8]: