Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alt tag to image widget on zoom #1942

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Adding alt tag to image widget on zoom #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a1a64
Adding alt tag to image widget on zoom + a quick test locally.
SonicScrewdriver Dec 2, 2024
c22f104
Undoing temporary storybook view
SonicScrewdriver Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-pandas-argue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Ensure that zoomed-in images retain alt text
1 change: 1 addition & 0 deletions packages/perseus/src/zoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ Zoom.prototype.zoomImage = function () {
}.bind(this);

img.src = this._targetImage.src;
img.alt = this._targetImage.alt;

this.$zoomedImage = $zoomedImage;
};
Expand Down
Loading