Refactor more findDOMNodes #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (13c9fe6) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1925If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1925 |
|
Size Change: -58 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jeremywiebe
approved these changes
Nov 28, 2024
Merged
daniellewhyte
added a commit
that referenced
this pull request
Dec 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1930](#1930) [`834bd8bfb`](834bd8b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove PerseusExampleWidgetOptions, PerseusSimpleMarkdownTesterWidgetOptions, and PerseusExampleWidgetOptions types - widgets no longer exist ### Minor Changes - [#1845](#1845) [`066daab0e`](066daab) Thanks [@daniellewhyte](https://github.com/daniellewhyte)! - Add labels to Dropdown widget ### Patch Changes - [#1904](#1904) [`83b1beab8`](83b1bea) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Storybook to v8.x - [#1925](#1925) [`89244ccc0`](89244cc) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove some uses of findDOMNode - Updated dependencies \[[`83b1beab8`](83b1bea)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#1845](#1845) [`066daab0e`](066daab) Thanks [@daniellewhyte](https://github.com/daniellewhyte)! - Add labels to Dropdown widget ### Patch Changes - [#1904](#1904) [`83b1beab8`](83b1bea) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Storybook to v8.x - [#1893](#1893) [`3d777d1c1`](3d777d1) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Removing usage of createReactClass from several component files. - Updated dependencies \[[`83b1beab8`](83b1bea), [`066daab0e`](066daab), [`834bd8bfb`](834bd8b), [`89244ccc0`](89244cc)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1904](#1904) [`83b1beab8`](83b1bea) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Storybook to v8.x ## @khanacademy/[email protected] ### Patch Changes - [#1904](#1904) [`83b1beab8`](83b1bea) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Storybook to v8.x - [#1904](#1904) [`83b1beab8`](83b1bea) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Storybook to v8.x - Updated dependencies \[[`83b1beab8`](83b1bea)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
More removal of findDOMNode which is deprecated