[Locked Labels + Aria] Create math only parser to help parse TeX how we want #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishasy
commented
Nov 20, 2024
| @@ -81,7 +82,7 @@ export function isUnlimitedGraphState( | |||
| export function replaceOutsideTeX(mathString: string) { | |||
| // All the information we need is in the first section, | |||
| // whether it's typed as "blockmath" or "paragraph" | |||
| const firstSection = SimpleMarkdown.parse(mathString)[0]; | |||
| const firstSection = parse(mathString)[0]; | |||
There was a problem hiding this comment.
Not making any changes here, just updating the import. This whole function will be updated in a different PR.
nishasy
requested review from
benchristel,
catandthemachines,
anakaren-rojas and
a team
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (860d91b) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1890If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1890 |
|
Size Change: +251 B (+0.02%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
anakaren-rojas
approved these changes
Nov 20, 2024
| @@ -148,3 +153,133 @@ describe("replaceOutsideTeX", () => { | |||
| expect(convertedString).toEqual("\\text{\\\\}"); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("mathOnlyParser", () => { | |||
There was a problem hiding this comment.
Are there any edge cases we should consider adding?
A few that I'm wondering about are yippee $x^2, yippee x^2$ and yippee x^2.
I know you cover ^ and $ in the table tests, but I'm curious about capturing them in the context of a string with other text
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Nov 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1905](#1905) [`9c225f936`](9c225f9) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're reverting work done for the Server Side Scoring and Input Number Conversion projects. ### Minor Changes - [#1883](#1883) [`adad642ab`](adad642) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Introduces a validation function for the matrix widget (extracted from matrix scoring function). - [#1878](#1878) [`a27f23bb4`](a27f23b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Add expression validator function ### Patch Changes - [#1890](#1890) [`0afb1a4f7`](0afb1a4) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels + Aria] Create math only parser to help parse TeX how we want - [#1889](#1889) [`55a532175`](55a5321) Thanks [@benchristel](https://github.com/benchristel)! - Internal: enable strict typechecking of function parameters - [#1852](#1852) [`4b8836b84`](4b8836b) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Adding open and closing behavior to unlimited polygon graph type. - Updated dependencies \[[`55a532175`](55a5321)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#1905](#1905) [`9c225f936`](9c225f9) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're reverting work done for the Server Side Scoring and Input Number Conversion projects. ### Patch Changes - [#1889](#1889) [`55a532175`](55a5321) Thanks [@benchristel](https://github.com/benchristel)! - Internal: enable strict typechecking of function parameters - Updated dependencies \[[`adad642ab`](adad642), [`0afb1a4f7`](0afb1a4), [`55a532175`](55a5321), [`9c225f936`](9c225f9), [`4b8836b84`](4b8836b), [`a27f23bb4`](a27f23b)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1889](#1889) [`55a532175`](55a5321) Thanks [@benchristel](https://github.com/benchristel)! - Internal: enable strict typechecking of function parameters ## @khanacademy/[email protected] ### Patch Changes - [#1889](#1889) [`55a532175`](55a5321) Thanks [@benchristel](https://github.com/benchristel)! - Internal: enable strict typechecking of function parameters ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`55a532175`](55a5321)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1889](#1889) [`55a532175`](55a5321) Thanks [@benchristel](https://github.com/benchristel)! - Internal: enable strict typechecking of function parameters ## @khanacademy/[email protected] ### Major Changes - [#1905](#1905) [`9c225f936`](9c225f9) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - We're reverting work done for the Server Side Scoring and Input Number Conversion projects. ### Patch Changes - Updated dependencies \[[`55a532175`](55a5321)]: - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected] - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to be able to parse a string meant for TeX into its most basic
essential parts. To do this, we are creating a
mathOnlyParser()parser.Using the default
parse()function from SimpleMarkdown breaks uptext into too many sections, and parsing from scratch can get very
complicated. The ideal way to do this is to use the existing
parserFor()function from SimpleMarkdown that lets us customize the parser.
This will be used in
it shows up correctly on the graph. Non-TeX should show up with regular
text styling and allow spaces.
rule engine will only be run on the math sections of the parsed output.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2548
(and also https://khanacademy.atlassian.net/browse/LEMS-2591)
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/utils.test.ts