-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AI files #1860
Rename AI files #1860
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (b70b3a7) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1860 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!! This is wonderful and very helpful 🙏
}); | ||
}); | ||
|
||
xit("should get prompt json which matches the state of the UI", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary:
There was discussion around the names of things in the AI folder being confusing.
What this PR does:
prompt-utils.ts
files to[widget]-ai-utils.ts
getPromptJSON
directly and (2) testinggetPromptJSON
on the widget export; I just combined these test files and renamed them to[widget]-ai-utils.test.ts
No real logic changes, just code shoveling.