[Locked Figure Aria] Use spoken math in locked figure settings autogen labels #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… within Locked Point aria labels
… label, update type on condenseTextNodes params
…labels When auto-generating the aria labels for locked figures, we want it to use words as if they were spoken rather than math expressions that might be read incorrectly by the screen reader. - Use the `generateSpokenMathDetails` utility within LockedLineSettings, following the pattern used in LockedPointSettings for this. - Update the locked line autogen function to include the labels on the locked points that define the locked line. Issue: https://khanacademy.atlassian.net/browse/LEMS-2548 Test plan: - `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-line-settings.test.tsx` Storybook - Go to http://localhost:6006/iframe.html?args=&id=perseuseditor-widgets-interactive-graph--mafs-with-locked-figure-labels-all-flags&viewMode=story - Open the locked line settings - Change the visible label to hvae a mix of TeX (with `$...$`) and non-TeX - Press the "Auto-generate" button - Confirm that the input changes to include spoken math words for the TeX - Also try this with no labels, multiple labels, and the labels changed for the locked points that define the line
…is clicked rather when the props are changed
…is clicked rather than when the props are changed
…n labels When auto-generating the aria labels for locked figures, we want it to use words as if they were spoken rather than math expressions that might be read incorrectly by the screen reader. - Use the `generateSpokenMathDetails` utility within LockedVectorSettings, LockedEllipseSettings, LockedPolygonSettings, and LockedFunctionSettings. Issue: https://khanacademy.atlassian.net/browse/LEMS-2548 Test plan: - `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-vector-settings.test.tsx` - `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-ellipse-settings.test.tsx` - `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-polygon-settings.test.tsx` - `yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-function-settings.test.tsx` Storybook - Go to http://localhost:6006/iframe.html?args=&id=perseuseditor-widgets-interactive-graph--mafs-with-locked-figure-labels-all-flags&viewMode=story - For each locked figure: - Open the figure settings - Change the visible label to have a mix of TeX and non-TeX - Press the "Auto-generate" button - Confirm that the input changes to include spoken math words for the TeX - Also try this with no labels, multiple labels, fully non-TeX, and fully teX labels.
nishasy
requested review from
benchristel,
catandthemachines,
anakaren-rojas and
a team
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7ee43a8) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1858If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1858 |
|
Size Change: -65 B (-0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
anakaren-rojas
approved these changes
Nov 14, 2024
|
Was playing around with the experience and I was noticing how it's reading out square roots. Is this expected behavior for it to read out "StartRoot one half EndRoot"? That doesn't feel natural, but maybe I'm not aware of the standard for reading out TeX. |
catandthemachines
approved these changes
Nov 15, 2024
| @@ -24,6 +24,14 @@ const defaultProps = { | |||
|
|
|||
| const defaultLabel = getDefaultFigureForType("label"); | |||
|
|
|||
| // Mock the async function generateSpokenMathDetails | |||
| jest.mock("./util", () => ({ | |||
There was a problem hiding this comment.
Love this mocking to help us identify the generated spoken math details in testing ❤️
|
@catandthemachines I agree that it's a bit awkward, but I believe that's the intended behavior. I think it's to make it more clear where the square root starts and ends for the cases in which the radicand is particularly complex. |
An error occurred while trying to automatically change base from
spoken-aria-lines
to
main
November 15, 2024 19:50
|
The parent pull-request (#1854) has been merged into |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When auto-generating the aria labels for locked figures, we want it to use
words as if they were spoken rather than math expressions that might be
read incorrectly by the screen reader.
generateSpokenMathDetailsutility within LockedVectorSettings,LockedEllipseSettings, LockedPolygonSettings, and LockedFunctionSettings.
prePopulatedAriaLabelandmake
getPrepopulatedAriaLabelrequired.Issue: https://khanacademy.atlassian.net/browse/LEMS-2548
Test plan:
yarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-vector-settings.test.tsxyarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-ellipse-settings.test.tsxyarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-polygon-settings.test.tsxyarn jest packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-function-settings.test.tsxStorybook
fully teX labels.