Remove unnecessary MathJax 2 logic from Perseus.Init #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: -276 B (-0.03%) Total Size: 859 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (fa98083) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1833If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1833 |
jeremywiebe
approved these changes
Nov 7, 2024
packages/perseus/src/init.ts
Outdated
| */ | ||
| const init = function (options: PerseusOptions): Promise<undefined> { | ||
| const init = function (): Promise<undefined> { |
There was a problem hiding this comment.
Given that there's nothing async in this function anymore, can you make it just const init = function() {?
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Nov 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#1834](#1834) [`429b9cc15`](429b9cc) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figures] Use \\$ symbols to denote TeX within locked labels and locked figure labels ### Patch Changes - [#1833](#1833) [`122b3cc1b`](122b3cc) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Removal of unused MathJax2 initialization ## @khanacademy/[email protected] ### Minor Changes - [#1834](#1834) [`429b9cc15`](429b9cc) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figures] Use \\$ symbols to denote TeX within locked labels and locked figure labels ### Patch Changes - Updated dependencies \[[`429b9cc15`](429b9cc), [`122b3cc1b`](122b3cc)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While investigating a regression on Webapp related to our Deprecated Stand-in Widget, we discovered we were initializing MathJax unnecessarily! This initialization is specifically for MathJax2 so it is safe to remove entirely.
Issue: LEMS-2588
Test plan: