Let interactive graph components render a screenreader description #1815
Conversation
benchristel
requested review from
anakaren-rojas,
catandthemachines and
nishasy
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: +203 B (+0.02%) Total Size: 857 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9e13cc0) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1815If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1815 |
| screenreaderDescription: null, | ||
| }; | ||
| } | ||
|
|
||
| export function AngleGraph(props: AngleGraphProps) { |
There was a problem hiding this comment.
Since all these graphs are no longer being rendered directly outside their respective files (<AngleGraph /> ==> renderAngleGraph()), can we remove the export for all of these?
There was a problem hiding this comment.
There's an index.ts file in this directory that exports most of the graph components. Perhaps we should remove that. If we did, then I think this wouldn't need to be exported.
There was a problem hiding this comment.
Is the index.ts file only for exporting things that would be used outside this package? I feel like we could probably remove that, but I don't think that should block this in any case.
There was a problem hiding this comment.
It seems that nothing imports from the index.ts file, so I'm going to remove it.
benchristel
force-pushed
the
benc/render-graph-refactor
branch
from
91ae0da to
368ac54
Compare
This refactoring will make it easy for each graph subtype (segment, point,
linear-system, etc.) to describe itself to a screenreader.
At this point, no graph actually renders a screenreader description. Future
PRs will add descriptions for each graph type.
Issue: https://khanacademy.atlassian.net/browse/LEMS-1725
Test plan:
yarn test