Wrap text node to reduce Google Translate bug #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: -33 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
|
Hrm. I've looked at this Sentry issue many times and had no idea where it came from. I wonder if it's all down to Google Translate or other DOM manipulation tooling? |
|
@jeremywiebe seems likely! |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (804b9b8) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1814If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1814 |
benchristel
approved these changes
Oct 31, 2024
| let color; | ||
| let backgroundColor: string | undefined; | ||
| let borderColor: string; | ||
| let color: string; |
There was a problem hiding this comment.
Thanks for fixing up these type issues!
mark-fitzgerald
approved these changes
Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Google Translate doesn't play nicely with React.
There is a known issue that Google plans to address... one day, maybe.
In the short term, it looks like if we wrap text nodes in elements, we should be good to go.
Issue: LEMS-2574
Testing:
Use Google Translate on any radio widget exercise and do something that causes the radio widgets to change state to render a text node (the easiest way was showing rationales). The red bar of doom doesn't show.