Remove unused optionRenderer prop on dropdown's Option component #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeremywiebe
requested review from
benchristel,
nishasy,
mark-fitzgerald,
handeyeco,
catandthemachines and
anakaren-rojas
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6637ed5) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1794If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1794 |
|
Size Change: -138 B (-0.02%) Total Size: 866 kB
ℹ️ View Unchanged
|
handeyeco
approved these changes
Oct 24, 2024
There were some shared components that Perseus used that we copied in from webapp. I can see this option being used in webapp's version of this component, but Perseus doesn't so we can clean it up here. |
Merged
benchristel
pushed a commit
that referenced
this pull request
Oct 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1799](#1799) [`f3139edfe`](f3139ed) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Change functional components to use default parameters instead of deprecated 'defaultProps' ## @khanacademy/[email protected] ### Patch Changes - [#1766](#1766) [`39e1292a9`](39e1292) Thanks [@Myranae](https://github.com/Myranae)! - Refine iFrame's Rubric type - [#1799](#1799) [`f3139edfe`](f3139ed) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Change functional components to use default parameters instead of deprecated 'defaultProps' - [#1765](#1765) [`5cf8d975b`](5cf8d97) Thanks [@Myranae](https://github.com/Myranae)! - Refine Sorter's Rubric type - [#1758](#1758) [`d6edf18ef`](d6edf18) Thanks [@Myranae](https://github.com/Myranae)! - Refine Radio's Rubric and UserInput types - [#1743](#1743) [`5ea5d5927`](5ea5d59) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - BUGFIX - [Numeric Input] - Check for wrong answers when scoring - [#1760](#1760) [`9426509cd`](9426509) Thanks [@Myranae](https://github.com/Myranae)! - Refine Matrix's Rubric and UserInput types - [#1761](#1761) [`dbe17d1ee`](dbe17d1) Thanks [@Myranae](https://github.com/Myranae)! - Refine NumericInput's Rubric type - Updated dependencies \[[`f3139edfe`](f3139ed)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1794](#1794) [`9dd0f8c56`](9dd0f8c) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove unused prop, optionRenderer, from dropdown-option component - Updated dependencies \[[`39e1292a9`](39e1292), [`f3139edfe`](f3139ed), [`5cf8d975b`](5cf8d97), [`d6edf18ef`](d6edf18), [`5ea5d5927`](5ea5d59), [`9426509cd`](9426509), [`dbe17d1ee`](dbe17d1)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`f3139edfe`](f3139ed)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As I was working in the code I noticed that the
optionRendererprop is never passed to the Option nor OptionGroup components. So I'm removing it.Issue: "none"
Test plan:
yarn typecheckyarn testrg optionRenderer(in hosting applications - webapp, mobile)