Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knip 7: remove unused style constants #1777

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Knip 7: remove unused style constants #1777

merged 7 commits into from
Oct 22, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 21, 2024

Summary:

I could see an argument for keeping these since they define a palette we could choose from. However, we're trying to more closely align with WB so I think we should think of that as our palette rather than maintaining our own.

@handeyeco handeyeco self-assigned this Oct 21, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 21, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to knip.config.ts, package.json, yarn.lock, .changeset/proud-ligers-learn.md, packages/perseus/src/styles/constants.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 21, 2024 16:57
@handeyeco handeyeco changed the title remove unused style constants Knip 7: remove unused style constants Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (51e0457) and published it to npm. You
can install it using the tag PR1777.

Example:

yarn add @khanacademy/perseus@PR1777

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1777

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Size Change: -448 B (-0.05%)

Total Size: 867 kB

Filename Size Change
packages/perseus/dist/es/index.js 419 kB -448 B (-0.11%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 281 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from add-knip to main October 22, 2024 14:57
@handeyeco handeyeco merged commit cf57871 into main Oct 22, 2024
9 checks passed
@handeyeco handeyeco deleted the knip-7 branch October 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants