Refine Label Image Rubric type #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (2110e61) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1756If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1756 |
|
Size Change: +92 B (+0.01%) Total Size: 866 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Myranae
commented
Oct 16, 2024
Comment on lines
+126
to
+128
| /* TODO(LEMS-2440): Should be removed or refactored. Grading info may need | ||
| to be moved to the rubric from userInput. */ | ||
| export type PerseusLabelImageRubric = Empty; |
There was a problem hiding this comment.
I originally just removed everything related to rubric, but I think we might want to pull answers out of userInput.
handeyeco
approved these changes
Oct 16, 2024
| @@ -317,7 +320,8 @@ export class LabelImage | |||
| return {markers}; | |||
| } | |||
|
|
|||
| showRationalesForCurrentlySelectedChoices(rubric: LabelImageProps) { | |||
| // TODO(LEMS-2440): Can possibly remove rubric parameter during 2440? Or refactor | |||
There was a problem hiding this comment.
Also kind of related to: https://khanacademy.atlassian.net/browse/LEMS-2519?focusedCommentId=337185
Here's a ticket specifically for this method: https://khanacademy.atlassian.net/browse/LEMS-2544
There was a problem hiding this comment.
Updated the comment to reference LEMS-2544.
| @@ -43,14 +43,15 @@ export function scoreMarker( | |||
| return score; | |||
| } | |||
|
|
|||
| // TODO(LEMS-2440): Can possibly remove rubric parameter during 2440? | |||
There was a problem hiding this comment.
For LabelImage I don't think we'll be able to remove rubric. It'll be something like:
type PerseusLabelImageUserInput = {
selected: ReadonlyArray<string>;
}
type PerseusLabelImageRubric = {
answers: ReadonlyArray<string>;
}We just have to untangle how LabelImage is mashing together WidgetOptions/Rubric/UserInput. No action needed right now, it'll be a part of LEMS-2440.
There was a problem hiding this comment.
Updated the comment to point out where answers is located.
Merged
mark-fitzgerald
pushed a commit
that referenced
this pull request
Oct 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1747](#1747) [`81ee69b0a`](81ee69b) Thanks [@kevinb-khan](https://github.com/kevinb-khan)! - Update nodes.js to use ES6 classes - [#1748](#1748) [`93bd39b6b`](93bd39b) Thanks [@kevinb-khan](https://github.com/kevinb-khan)! - Convert nodes.js to use TypeScript ## @khanacademy/[email protected] ### Patch Changes - [#1751](#1751) [`c95d08056`](c95d080) Thanks [@Myranae](https://github.com/Myranae)! - Refine InputNumber's rubric type - [#1756](#1756) [`3a208ba12`](3a208ba) Thanks [@Myranae](https://github.com/Myranae)! - Refine LabelImage's Rubric type - [#1762](#1762) [`a0f438fd7`](a0f438f) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - BUGFIX - [Number Line] - Some exercises with fractions wouldn't render - Updated dependencies \[[`81ee69b0a`](81ee69b), [`93bd39b6b`](93bd39b)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`81ee69b0a`](81ee69b), [`c95d08056`](c95d080), [`93bd39b6b`](93bd39b), [`3a208ba12`](3a208ba), [`a0f438fd7`](a0f438f)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`81ee69b0a`](81ee69b), [`93bd39b6b`](93bd39b)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As part of the Server Side Scoring project, this refactors Label Image's Rubric type based on current usage. It is not currently used in this widget. As we plan to review the use of rubric during LEMS-2440, the Rubric type was left in but changed to
Empty. It was also added in one place where rubric was listed as a parameter (but was not in use).Issue: LEMS-2468
Test plan: