Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getGrammarTypeForPath #1740

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Remove getGrammarTypeForPath #1740

merged 2 commits into from
Oct 23, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 11, 2024

Summary:

Pretty sure based on the comments, searching for uses, and this message that this is just dead code.

@handeyeco handeyeco self-assigned this Oct 11, 2024
@khan-actions-bot khan-actions-bot requested a review from a team October 11, 2024 14:48
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 11, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/tough-socks-fail.md, packages/perseus/src/renderer.tsx, packages/perseus/src/server-item-renderer.tsx, packages/perseus/src/types.ts, packages/perseus/src/__tests__/renderer.test.tsx, packages/perseus/src/__tests__/server-item-renderer.test.tsx, packages/perseus/src/widgets/expression/expression.tsx, packages/perseus/src/widgets/input-number/input-number.tsx, packages/perseus/src/widgets/matrix/matrix.tsx, packages/perseus/src/widgets/number-line/number-line.tsx, packages/perseus/src/widgets/numeric-input/numeric-input.tsx, packages/perseus/src/widgets/table/table.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (dc263a3) and published it to npm. You
can install it using the tag PR1740.

Example:

yarn add @khanacademy/perseus@PR1740

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1740

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Size Change: -289 B (-0.03%)

Total Size: 865 kB

Filename Size Change
packages/perseus/dist/es/index.js 419 kB -289 B (-0.07%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 280 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@handeyeco handeyeco merged commit c6ee266 into main Oct 23, 2024
11 of 15 checks passed
@handeyeco handeyeco deleted the rm-getGrammarTypeForPath branch October 23, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants