Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InteractiveGraphEditor to a directory #1590

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Move InteractiveGraphEditor to a directory #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3dbc4c
Move InteractiveGraphEditor to a directory
benchristel Sep 4, 2024
eee28a3
Add changeset
benchristel Sep 4, 2024
edb4764
Fix formatting
benchristel Sep 4, 2024
0242217
Rename index.tsx to interactive-graph-editor.tsx
benchristel Sep 5, 2024
5f18a19
Remove unused import
benchristel Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/tricky-forks-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/perseus": patch
"@khanacademy/perseus-editor": patch
---

Internal: Move InteractiveGraphEditor to its own directory
2 changes: 1 addition & 1 deletion packages/perseus-editor/src/all-editors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import IframeEditor from "./widgets/iframe-editor";
import ImageEditor from "./widgets/image-editor";
import InputNumberEditor from "./widgets/input-number-editor";
import InteractionEditor from "./widgets/interaction-editor";
import InteractiveGraphEditor from "./widgets/interactive-graph-editor";
import InteractiveGraphEditor from "./widgets/interactive-graph-editor/interactive-graph-editor";
import LabelImageEditor from "./widgets/label-image-editor";
import MatcherEditor from "./widgets/matcher-editor";
import MatrixEditor from "./widgets/matrix-editor";
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus-editor/src/components/graph-locked-figures/locked-figures-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import LockedFigureSelect from "./locked-figure-select";
import LockedFigureSettings from "./locked-figure-settings";

import type {LockedFigureSettingsMovementType} from "./locked-figure-settings-actions";
import type {Props as InteractiveGraphEditorProps} from "../../widgets/interactive-graph-editor";
import type {Props as InteractiveGraphEditorProps} from "../../widgets/interactive-graph-editor/interactive-graph-editor";
import type {LockedFigure, LockedFigureType} from "@khanacademy/perseus";

type Props = {
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus-editor/src/widgets/__stories__/interactive-graph-editor.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from "react";

import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import InteractiveGraphEditorArgTypes from "./interactive-graph-editor.argtypes";

Expand Down
2 changes: 1 addition & 1 deletion ...ges/perseus-editor/src/widgets/__tests__/interactive-graph-editor-locked-figures.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as React from "react";
import {testDependencies} from "../../../../../testing/test-dependencies";
import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import type {PerseusGraphType} from "@khanacademy/perseus";
import type {UserEvent} from "@testing-library/user-event";
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {testDependencies} from "../../../../../testing/test-dependencies";
import {waitForInitialGraphieRender} from "../../../../../testing/wait";
import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import type {PerseusGraphType} from "@khanacademy/perseus";
import type {PropsFor} from "@khanacademy/wonder-blocks-core";
Expand Down
20 changes: 10 additions & 10 deletions .../src/widgets/interactive-graph-editor.tsx → ...graph-editor/interactive-graph-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ import {StyleSheet} from "aphrodite";
import * as React from "react";
import _ from "underscore";

import LabeledRow from "../components/graph-locked-figures/labeled-row";
import LockedFiguresSection from "../components/graph-locked-figures/locked-figures-section";
import GraphPointsCountSelector from "../components/graph-points-count-selector";
import GraphTypeSelector from "../components/graph-type-selector";
import {InteractiveGraphCorrectAnswer} from "../components/interactive-graph-correct-answer";
import InteractiveGraphSettings from "../components/interactive-graph-settings";
import SegmentCountSelector from "../components/segment-count-selector";
import StartCoordsSettings from "../components/start-coords-settings";
import {shouldShowStartCoordsUI} from "../components/util";
import {parsePointCount} from "../util/points";
import LabeledRow from "../../components/graph-locked-figures/labeled-row";
import LockedFiguresSection from "../../components/graph-locked-figures/locked-figures-section";
import GraphPointsCountSelector from "../../components/graph-points-count-selector";
import GraphTypeSelector from "../../components/graph-type-selector";
import {InteractiveGraphCorrectAnswer} from "../../components/interactive-graph-correct-answer";
import InteractiveGraphSettings from "../../components/interactive-graph-settings";
import SegmentCountSelector from "../../components/segment-count-selector";
import StartCoordsSettings from "../../components/start-coords-settings";
import {shouldShowStartCoordsUI} from "../../components/util";
import {parsePointCount} from "../../util/points";

import type {
PerseusImageBackground,
Expand Down