Remove "sort-comp" exceptions #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd91f7f.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
changed the title
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (3ee52cc) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1583If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1583 |
|
Size Change: +454 B (+0.05%) Total Size: 861 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
+ Coverage 70.34% 70.70% +0.35%
==========================================
Files 521 544 +23
Lines 107316 111297 +3981
Branches 5513 11872 +6359
==========================================
+ Hits 75489 78689 +3200
- Misses 31711 32608 +897
+ Partials 116 0 -116 see 1065 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeremywiebe
approved these changes
Sep 4, 2024
aemandine
added a commit
that referenced
this pull request
Sep 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1577](#1577) [`c875acd01`](c875acd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove example widgets and their editors ### Minor Changes - [#1570](#1570) [`c4432ffad`](c4432ff) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Remove unlimited points via keyboard - [#1582](#1582) [`377b7ce68`](377b7ce) Thanks [@aemandine](https://github.com/aemandine)! - Add save warnings to PhET widget editor and un-hide widget from content editor widget dropdown ### Patch Changes - [#1578](#1578) [`78bb8573e`](78bb857) Thanks [@aemandine](https://github.com/aemandine)! - Remove simpleValidate from PhET widget - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder - [#1589](#1589) [`d56952564`](d569525) Thanks [@aemandine](https://github.com/aemandine)! - Make PhET widget smaller - [#1587](#1587) [`8015cdefb`](8015cde) Thanks [@aemandine](https://github.com/aemandine)! - Tidying up PhET widget - [#1583](#1583) [`615567bd2`](615567b) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove sort-comp exceptions and reorder components ## @khanacademy/[email protected] ### Major Changes - [#1577](#1577) [`c875acd01`](c875acd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove example widgets and their editors ### Minor Changes - [#1582](#1582) [`377b7ce68`](377b7ce) Thanks [@aemandine](https://github.com/aemandine)! - Add save warnings to PhET widget editor and un-hide widget from content editor widget dropdown ### Patch Changes - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder - [#1587](#1587) [`8015cdefb`](8015cde) Thanks [@aemandine](https://github.com/aemandine)! - Tidying up PhET widget - [#1583](#1583) [`615567bd2`](615567b) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove sort-comp exceptions and reorder components - Updated dependencies \[[`78bb8573e`](78bb857), [`a6ec402c0`](a6ec402), [`d56952564`](d569525), [`c875acd01`](c875acd), [`8015cdefb`](8015cde), [`c4432ffad`](c4432ff), [`615567bd2`](615567b), [`377b7ce68`](377b7ce)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1585](#1585) [`a6ec402c0`](a6ec402) Thanks [@handeyeco](https://github.com/handeyeco)! - Reorganize files in the widgets folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The only thing this PR does is it removes
sort-compESLint exceptions and fixes the sort order. See: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/sort-comp.mdI didn't do:
interactive-graph.tsxsince I didn't want to cause merge conflicts for that team