-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PhET Sim widget to be called PhET Simulation #1549
Conversation
Size Change: -19 kB (-2.16%) Total Size: 861 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 70.37% 70.91% +0.53%
==========================================
Files 520 523 +3
Lines 107231 107264 +33
Branches 7812 11043 +3231
==========================================
+ Hits 75468 76065 +597
+ Misses 31579 31199 -380
+ Partials 184 0 -184
... and 141 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1549](#1549) [`cae713da5`](cae713d) Thanks [@aemandine](https://github.com/aemandine)! - Refactor PhET Sim widget name to PhET Simulation ## @khanacademy/[email protected] ### Patch Changes - [#1550](#1550) [`7c5de59f2`](7c5de59) Thanks [@nishasy](https://github.com/nishasy)! - [Locked labels] Bugfix from merge conflict: Add back locked label settings - [#1549](#1549) [`cae713da5`](cae713d) Thanks [@aemandine](https://github.com/aemandine)! - Refactor PhET Sim widget name to PhET Simulation - Updated dependencies \[[`cae713da5`](cae713d)]: - @khanacademy/[email protected]
Summary:
Issue: LEMS-2284
Test plan:
yarn jest packages/perseus/src/widgets/__tests__/phet-simulation.test.ts
yarn jest packages/perseus-editor/src/widgets/__tests__/phet-simulation-editor.test.tsx