Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhET Sim widget to be called PhET Simulation #1549

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

aemandine
Copy link
Contributor

@aemandine aemandine commented Aug 23, 2024

Summary:

  • Refactors PhET Simulation widget to include full word "simulation" instead of abbreviation "sim"
  • Adds a missing peer dependency for Wonder Blocks Icon Button

Issue: LEMS-2284

Test plan:

  • Verify that the PhET widget and content editor work on Storybook
  • yarn jest packages/perseus/src/widgets/__tests__/phet-simulation.test.ts
  • yarn jest packages/perseus-editor/src/widgets/__tests__/phet-simulation-editor.test.tsx

@aemandine aemandine self-assigned this Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Size Change: -19 kB (-2.16%)

Total Size: 861 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 277 kB +8 B (0%)
packages/perseus/dist/es/index.js 417 kB -19 kB (-4.36%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (ad3d3d7) to head (b94518d).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/perseus/src/widgets/phet-simulation.tsx 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   70.37%   70.91%   +0.53%     
==========================================
  Files         520      523       +3     
  Lines      107231   107264      +33     
  Branches     7812    11043    +3231     
==========================================
+ Hits        75468    76065     +597     
+ Misses      31579    31199     -380     
+ Partials      184        0     -184     

Impacted file tree graph

Files Coverage Δ
packages/perseus-editor/src/all-editors.ts 100.00% <100.00%> (ø)
...seus-editor/src/widgets/phet-simulation-editor.tsx 91.07% <100.00%> (ø)
packages/perseus/src/extra-widgets.ts 100.00% <100.00%> (ø)
packages/perseus/src/index.ts 100.00% <100.00%> (ø)
packages/perseus/src/util/widget-enum-utils.ts 94.20% <100.00%> (ø)
packages/perseus/src/widgets/phet-simulation.tsx 75.67% <77.77%> (ø)

... and 141 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3d3d7...b94518d. Read the comment docs.

@aemandine aemandine changed the title Rename PhET editor story and tests Refactor PhET Sim widget to be called PhET Simulation Aug 23, 2024
Copy link
Contributor

@Myranae Myranae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aemandine aemandine marked this pull request as ready for review August 23, 2024 21:20
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/shy-jeans-reply.md, packages/perseus/package.json, packages/perseus/src/extra-widgets.ts, packages/perseus/src/index.ts, packages/perseus/src/perseus-types.ts, packages/perseus-editor/src/all-editors.ts, packages/perseus/src/util/widget-enum-utils.ts, packages/perseus/src/widgets/phet-simulation.tsx, packages/perseus-editor/src/widgets/phet-simulation-editor.tsx, packages/perseus/src/widgets/__stories__/phet-simulation.stories.tsx, packages/perseus/src/widgets/__testdata__/phet-simulation.testdata.ts, packages/perseus/src/widgets/__tests__/phet-simulation.test.ts, packages/perseus-editor/src/widgets/__stories__/phet-simulation-editor.stories.tsx, packages/perseus-editor/src/widgets/__tests__/phet-simulation-editor.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@aemandine aemandine merged commit cae713d into main Aug 23, 2024
20 of 28 checks passed
@aemandine aemandine deleted the am/phet-sim-to-phet-simulation branch August 23, 2024 21:41
aemandine added a commit that referenced this pull request Aug 26, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/[email protected]

### Patch Changes

- [#1549](#1549)
[`cae713da5`](cae713d)
Thanks [@aemandine](https://github.com/aemandine)! - Refactor PhET Sim
widget name to PhET Simulation

## @khanacademy/[email protected]

### Patch Changes

- [#1550](#1550)
[`7c5de59f2`](7c5de59)
Thanks [@nishasy](https://github.com/nishasy)! - [Locked labels] Bugfix
from merge conflict: Add back locked label settings


- [#1549](#1549)
[`cae713da5`](cae713d)
Thanks [@aemandine](https://github.com/aemandine)! - Refactor PhET Sim
widget name to PhET Simulation

- Updated dependencies
\[[`cae713da5`](cae713d)]:
    -   @khanacademy/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants