Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design updates #1542

Merged
merged 9 commits into from
Aug 22, 2024

Remove implicit null checks and add type notations

54539b3
Select commit
Loading
Failed to load commit list.
Merged

Design updates #1542

Remove implicit null checks and add type notations
54539b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (phet-widget@6e102f9). Learn more about missing BASE report.

Files Patch % Lines
packages/perseus/src/widgets/phet-sim.tsx 84.37% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             phet-widget    #1542   +/-   ##
==============================================
  Coverage               ?   70.60%           
==============================================
  Files                  ?      520           
  Lines                  ?   106657           
  Branches               ?    10919           
==============================================
  Hits                   ?    75309           
  Misses                 ?    31348           
  Partials               ?        0           

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/widgets/phet-sim.tsx 75.67% <84.37%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e102f9...54539b3. Read the comment docs.