-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🔥AUDIT🔥] Revert PR #1521: ContentPreview component #1536
Conversation
This reverts commit a9292af.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: -51 B (-0.01%) Total Size: 856 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (08d7645) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1536 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1536 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
+ Coverage 70.05% 70.60% +0.54%
==========================================
Files 515 517 +2
Lines 106293 106322 +29
Branches 7655 11497 +3842
==========================================
+ Hits 74467 75068 +601
+ Misses 31638 31254 -384
+ Partials 188 0 -188
... and 141 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)" ## @khanacademy/[email protected] ### Major Changes - [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)" ### Patch Changes - Updated dependencies \[[`78a5558f9`](78a5558)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Major Changes - [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)" Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1537
This reverts commit 78a5558.
This reverts commit 78a5558.
This reverts commit 78a5558.
Summary:
While working on the new
ContentPreview
component, I needed to migrate the ToolTip used for showing Lint issues to WonderBlocks.I noticed this was an issue in prod when doing the deploy of Perseus v29 and aborted the deploy.
I haven't figured this out yet and so I'm reverting the change to unblock releases for other folks.
Issue: LEMS-1809
Test plan: