Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Revert PR #1521: ContentPreview component #1536

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

While working on the new ContentPreview component, I needed to migrate the ToolTip used for showing Lint issues to WonderBlocks.

I noticed this was an issue in prod when doing the deploy of Perseus v29 and aborted the deploy.

I haven't figured this out yet and so I'm reverting the change to unblock releases for other folks.

Issue: LEMS-1809

Test plan:

@jeremywiebe jeremywiebe self-assigned this Aug 21, 2024
@jeremywiebe jeremywiebe changed the title Revert PR #1521: ContentPreview component [🔥AUDIT🔥] Revert PR #1521: ContentPreview component Aug 21, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review August 21, 2024 16:43
@khan-actions-bot khan-actions-bot requested a review from a team August 21, 2024 16:44
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Aug 21, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/khaki-mugs-watch.md, dev/vite.config.ts, packages/perseus-editor/package.json, packages/perseus-editor/src/index.ts, packages/perseus/src/__testdata__/article-renderer.testdata.ts, packages/perseus/src/__tests__/server-item-renderer.test.tsx, packages/perseus/src/components/lint.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Size Change: -51 B (-0.01%)

Total Size: 856 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 276 kB -765 B (-0.28%)
packages/perseus/dist/es/index.js 414 kB +714 B (+0.17%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.29 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (08d7645) and published it to npm. You
can install it using the tag PR1536.

Example:

yarn add @khanacademy/perseus@PR1536

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1536

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 88.03419% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.60%. Comparing base (0ae38af) to head (08d7645).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/perseus/src/components/lint.tsx 88.03% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
+ Coverage   70.05%   70.60%   +0.54%     
==========================================
  Files         515      517       +2     
  Lines      106293   106322      +29     
  Branches     7655    11497    +3842     
==========================================
+ Hits        74467    75068     +601     
+ Misses      31638    31254     -384     
+ Partials      188        0     -188     

Impacted file tree graph

Files Coverage Δ
packages/perseus-editor/src/index.ts 100.00% <ø> (ø)
packages/perseus/src/components/lint.tsx 87.79% <88.03%> (-0.08%) ⬇️

... and 141 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae38af...08d7645. Read the comment docs.

@jeremywiebe jeremywiebe merged commit 78a5558 into main Aug 21, 2024
11 checks passed
@jeremywiebe jeremywiebe deleted the jer/revert-lint branch August 21, 2024 16:54
jeremywiebe pushed a commit that referenced this pull request Aug 21, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/[email protected]

### Major Changes

-   [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)"

## @khanacademy/[email protected]

### Major Changes

-   [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)"

### Patch Changes

-   Updated dependencies \[[`78a5558f9`](78a5558)]:
    -   @khanacademy/[email protected]

## @khanacademy/[email protected]

### Major Changes

-   [#1536](#1536) [`78a5558f9`](78a5558) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Revert introduction of ContentPreview component (broke editor linting tooltip)"

Author: khan-actions-bot

Reviewers: jeremywiebe

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1537
jeremywiebe added a commit that referenced this pull request Aug 21, 2024
jeremywiebe added a commit that referenced this pull request Aug 27, 2024
jeremywiebe added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants