-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter to check Expression button sets #1531
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9a62e3f) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1531 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1531 |
Size Change: +409 B (+0.05%) Total Size: 854 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## LEMS-2199/prework #1531 +/- ##
=====================================================
- Coverage 71.75% 70.59% -1.16%
=====================================================
Files 520 514 -6
Lines 106610 105759 -851
Branches 11948 11458 -490
=====================================================
- Hits 76495 74665 -1830
- Misses 30115 31094 +979
... and 83 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
## Summary: Just trying to tidy up before addressing LEMS-2199 ([followup PR](#1531)) Issue: [LEMS-2199](https://khanacademy.atlassian.net/browse/LEMS-2199) [LEMS-2199]: https://khanacademy.atlassian.net/browse/LEMS-2199?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Author: handeyeco Reviewers: SonicScrewdriver, benchristel, handeyeco Required Reviewers: Approved By: SonicScrewdriver, benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1499
Summary:
Checks Expression answers to see if they require a symbol that's not available to the keypad.
Issue: LEMS-2199
Test plan:
\\sqrt
to an answer