Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a SharedRendererProps type #1530

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Make a SharedRendererProps type #1530

merged 2 commits into from
Aug 22, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Aug 19, 2024

Summary:

I don't know how useful this is, but this is my motivation: https://github.com/Khan/webapp/pull/24684

Test plan:

Nothing should change but types

@handeyeco handeyeco self-assigned this Aug 19, 2024
@khan-actions-bot khan-actions-bot requested a review from a team August 19, 2024 16:08
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Aug 19, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/stupid-parrots-chew.md, packages/perseus/src/article-renderer.tsx, packages/perseus/src/hint-renderer.tsx, packages/perseus/src/index.ts, packages/perseus/src/server-item-renderer.tsx, packages/perseus/src/types.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@handeyeco handeyeco changed the title make a SharedRendererProps type Make a SharedRendererProps type Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (98e2ec7) and published it to npm. You
can install it using the tag PR1530.

Example:

yarn add @khanacademy/perseus@PR1530

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1530

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Size Change: +412 B (+0.05%)

Total Size: 856 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 277 kB +303 B (+0.11%)
packages/perseus/dist/es/index.js 414 kB +109 B (+0.03%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.29 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think eventually we would refactor that shared type away, but today it makes sense to have it for the preview system.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (2509713) to head (98e2ec7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   70.14%   70.55%   +0.40%     
==========================================
  Files         516      518       +2     
  Lines      106239   106323      +84     
  Branches     7622    11514    +3892     
==========================================
+ Hits        74526    75018     +492     
+ Misses      31596    31305     -291     
+ Partials      117        0     -117     

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/article-renderer.tsx 79.08% <100.00%> (-0.16%) ⬇️
packages/perseus/src/hint-renderer.tsx 90.78% <100.00%> (-0.18%) ⬇️
packages/perseus/src/index.ts 100.00% <100.00%> (ø)
packages/perseus/src/server-item-renderer.tsx 83.63% <100.00%> (+0.03%) ⬆️

... and 119 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2509713...98e2ec7. Read the comment docs.

@handeyeco handeyeco merged commit 811f914 into main Aug 22, 2024
11 checks passed
@handeyeco handeyeco deleted the shared-renderer-type branch August 22, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants