-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a SharedRendererProps type #1530
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (98e2ec7) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1530 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1530 |
Size Change: +412 B (+0.05%) Total Size: 856 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think eventually we would refactor that shared type away, but today it makes sense to have it for the preview system.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
+ Coverage 70.14% 70.55% +0.40%
==========================================
Files 516 518 +2
Lines 106239 106323 +84
Branches 7622 11514 +3892
==========================================
+ Hits 74526 75018 +492
+ Misses 31596 31305 -291
+ Partials 117 0 -117
... and 119 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Summary:
I don't know how useful this is, but this is my motivation: https://github.com/Khan/webapp/pull/24684
Test plan:
Nothing should change but types