-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LEMS-2083): fix color contrast issues #1501
fix(LEMS-2083): fix color contrast issues #1501
Conversation
Size Change: +2.75 kB (+0.32%) Total Size: 856 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 70.03% 70.76% +0.73%
==========================================
Files 511 516 +5
Lines 105590 106101 +511
Branches 5405 10878 +5473
==========================================
+ Hits 73949 75084 +1135
+ Misses 31524 31017 -507
+ Partials 117 0 -117
... and 150 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (8f24178) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1501 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small tweak suggestions. Thanks for addressing this.
Co-authored-by: Matthew <[email protected]>
Co-authored-by: Matthew <[email protected]>
Summary:
Issue: LEMS-2083
Test plan:
Expected behavior
(Step 3)
(Step 4)
Screenshots
Before
Screen.Recording.2024-08-08.at.3.40.26.PM.mov
After
Screen.Recording.2024-08-08.at.3.36.51.PM.mov