-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting portal disable functionality, causing clipping behavior. #1461
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (b8c887c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1461 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1461 |
Size Change: +180 B (+0.02%) Total Size: 849 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cat!
* to wait for the WonderBlock Popover to move to the correct | ||
* location and scroll the user to the correct location. | ||
* */ | ||
timeout = setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed it because without the portal it was no longer necessary. Now that we're doing portaling again we need the timeout behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 69.66% 70.31% +0.64%
==========================================
Files 506 509 +3
Lines 104885 104938 +53
Branches 7561 11371 +3810
==========================================
+ Hits 73071 73784 +713
+ Misses 31626 31154 -472
+ Partials 188 0 -188
... and 144 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Summary:
Adding back portal functionality for Expression Widget to ensure it does not get clipped.
This implementation was originally added in this PR: #1424
Issue: LEMS-2224
Test plan:
Go to https://khan.github.io/perseus/?path=/story/perseus-widgets-expression--desktop-kitchen-sink
Confirm that you have to tab through all the tab pannels to get the the main keypad, instead of going directly to the keypad.