Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting portal disable functionality, causing clipping behavior. #1461

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

catandthemachines
Copy link
Member

@catandthemachines catandthemachines commented Jul 30, 2024

Summary:

Adding back portal functionality for Expression Widget to ensure it does not get clipped.

This implementation was originally added in this PR: #1424

Issue: LEMS-2224

Test plan:

Go to https://khan.github.io/perseus/?path=/story/perseus-widgets-expression--desktop-kitchen-sink
Confirm that you have to tab through all the tab pannels to get the the main keypad, instead of going directly to the keypad.

@catandthemachines catandthemachines self-assigned this Jul 30, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jul 30, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/young-clocks-walk.md, packages/perseus/src/components/math-input.tsx, packages/math-input/src/components/keypad/keypad-mathquill.stories.tsx, packages/math-input/src/components/tabbar/item.tsx, packages/perseus/src/components/__tests__/math-input.test.tsx, packages/math-input/src/components/keypad/__tests__/__snapshots__/keypad.test.tsx.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team July 30, 2024 16:57
@catandthemachines catandthemachines changed the title Reverting portaling behavior that's blocking users. Reverting portal disable functionality, causing clipping behavior. Jul 30, 2024
Copy link
Contributor

github-actions bot commented Jul 30, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (b8c887c) and published it to npm. You
can install it using the tag PR1461.

Example:

yarn add @khanacademy/perseus@PR1461

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1461

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Size Change: +180 B (+0.02%)

Total Size: 849 kB

Filename Size Change
packages/math-input/dist/es/index.js 80.8 kB +190 B (+0.24%)
packages/perseus/dist/es/index.js 411 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 270 kB
packages/perseus-linter/dist/es/index.js 21.6 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cat!

* to wait for the WonderBlock Popover to move to the correct
* location and scroll the user to the correct location.
* */
timeout = setTimeout(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the revert?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed it because without the portal it was no longer necessary. Now that we're doing portaling again we need the timeout behavior.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (b9087f7) to head (b8c887c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   69.66%   70.31%   +0.64%     
==========================================
  Files         506      509       +3     
  Lines      104885   104938      +53     
  Branches     7561    11371    +3810     
==========================================
+ Hits        73071    73784     +713     
+ Misses      31626    31154     -472     
+ Partials      188        0     -188     

Impacted file tree graph

Files Coverage Δ
packages/math-input/src/components/tabbar/item.tsx 100.00% <100.00%> (+0.64%) ⬆️
packages/perseus/src/components/math-input.tsx 81.78% <ø> (+1.10%) ⬆️

... and 144 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9087f7...b8c887c. Read the comment docs.

@catandthemachines catandthemachines merged commit 2e8022a into main Jul 30, 2024
11 checks passed
@catandthemachines catandthemachines deleted the catjohnson/revert-portal-disabled branch July 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants