-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use :focus-visible to show focus indictor on polygon #1458
Use :focus-visible to show focus indictor on polygon #1458
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9515cbb) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1458 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1458 |
Size Change: -89 B (-0.01%) Total Size: 850 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tb/LEMS-2200/remove-line-weight-after-moving-polygon #1458 +/- ##
========================================================================================
+ Coverage 70.11% 70.29% +0.18%
========================================================================================
Files 508 508
Lines 105054 105051 -3
Branches 10691 10718 +27
========================================================================================
+ Hits 73656 73848 +192
+ Misses 31398 31203 -195
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -16,7 +16,6 @@ interface PolygonAngleProps { | |||
centerPoint: vec.Vector2; | |||
endPoints: [vec.Vector2, vec.Vector2]; | |||
polygonLines: readonly CollinearTuple[]; | |||
active: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prop wasn't used. Removing it so we can remove the logic to compute its value in polygon.tsx
.
Tamara incorporated these changes into #1455 manually, so there's no need for this PR to stay open. Closing. |
I felt like suggesting these changes inline on #1455 would be too cumbersome, so I'm doing it in a PR instead.