Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Expression w/ Label POC #1378

Closed
wants to merge 2 commits into from
Closed

WIP: Expression w/ Label POC #1378

wants to merge 2 commits into from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jun 26, 2024

Summary:

Desktop:

Screenshot 2024-06-26 at 4 20 17 PM

Mobile:

Screenshot 2024-06-26 at 4 20 48 PM

Issue: LEMS-2114

@handeyeco handeyeco self-assigned this Jun 26, 2024
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to packages/perseus/src/components/math-input.tsx, packages/perseus/src/styles/perseus-renderer.less, packages/perseus/src/widgets/expression.tsx, packages/math-input/src/components/input/math-input.tsx, packages/perseus/src/widgets/__stories__/expression.stories.tsx, packages/perseus/src/widgets/__testdata__/expression.testdata.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team June 26, 2024 21:19
@handeyeco handeyeco changed the title POC mobile input WIP: Expression w/ Label POC Jun 26, 2024
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (45e0506) and published it to npm. You
can install it using the tag PR1378.

Example:

yarn add @khanacademy/perseus@PR1378

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1378

Copy link
Contributor

Size Change: +394 B (+0.05%)

Total Size: 847 kB

Filename Size Change
packages/math-input/dist/es/index.js 80.1 kB -5 B (-0.01%)
packages/perseus/dist/es/index.js 408 kB +399 B (+0.1%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-editor/dist/es/index.js 272 kB
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: where is the best place to get test data like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll DM you (I'm always a little hesitant to post links to internal tools on GH).

@handeyeco
Copy link
Contributor Author

Closing in favor of #1404

@handeyeco handeyeco closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants