Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LEMS-2082): update expression popover role and remove aria-checked #1371

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Jun 21, 2024

Summary:

Issue Summary

Based on a Level Access audit, the keypad button in the expression widget

  • doesn't have the appropriate role
  • misuses the aria-checked label

Fix Summary

  • Updated Clickable component's role to be button
  • Removed aria-checked

Issue: LEMS-2082

Test plan:

  1. Navigate to Expression Widget
  2. Click the expression widget
    image
  3. Fix reflects updated component role and does not display 'aria-checked'

Screenshots

Before

image

After

image

@anakaren-rojas anakaren-rojas self-assigned this Jun 21, 2024
@khan-actions-bot khan-actions-bot requested a review from a team June 21, 2024 21:01
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jun 21, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/tidy-zebras-dream.md, packages/perseus/src/components/math-input.tsx, packages/perseus/src/components/__tests__/math-input.test.tsx, packages/perseus-editor/src/widgets/__tests__/expression-editor.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (076a10c) and published it to npm. You
can install it using the tag PR1371.

Example:

yarn add @khanacademy/perseus@PR1371

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1371

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Size Change: -13 B (0%)

Total Size: 845 kB

Filename Size Change
packages/perseus/dist/es/index.js 407 kB -13 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-editor/dist/es/index.js 272 kB
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.26%. Comparing base (9615106) to head (076a10c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1371      +/-   ##
==========================================
+ Coverage   69.74%   71.26%   +1.51%     
==========================================
  Files         491      495       +4     
  Lines      103844   103926      +82     
  Branches     7498    11224    +3726     
==========================================
+ Hits        72426    74061    +1635     
+ Misses      31240    29865    -1375     
+ Partials      178        0     -178     

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/components/math-input.tsx 81.02% <100.00%> (-0.61%) ⬇️

... and 140 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9615106...076a10c. Read the comment docs.

@anakaren-rojas anakaren-rojas changed the title update expression popover role and remove aria-checked fix(LEMS-2082): update expression popover role and remove aria-checked Jun 24, 2024
Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Anakaren!

@anakaren-rojas anakaren-rojas merged commit ba5f334 into main Jun 25, 2024
25 of 29 checks passed
@anakaren-rojas anakaren-rojas deleted the LEMS-2082-update-expression-attributes branch June 25, 2024 17:25
anakaren-rojas added a commit that referenced this pull request Jun 25, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/[email protected]

### Major Changes

- [#1371](#1371)
[`ba5f33460`](ba5f334)
Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update
attributes for expression widget button

### Patch Changes

- [#1364](#1364)
[`35651e097`](35651e0)
Thanks [@Myranae](https://github.com/Myranae)! - Fix a bug in the
exercise editor where the preview did not update after a change to the
number of sides in polygon graphs


- [#1373](#1373)
[`961510673`](9615106)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Update the interactive graph builder with all currently migrated graph
types

## @khanacademy/[email protected]

### Major Changes

- [#1371](#1371)
[`ba5f33460`](ba5f334)
Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update
attributes for expression widget button

### Patch Changes

- [#1373](#1373)
[`961510673`](9615106)
Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph]
Update the interactive graph builder with all currently migrated graph
types

- Updated dependencies
\[[`35651e097`](35651e0),
[`961510673`](9615106),
[`ba5f33460`](ba5f334)]:
    -   @khanacademy/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants