-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(LEMS-2082): update expression popover role and remove aria-checked #1371
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (076a10c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1371 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1371 |
Size Change: -13 B (0%) Total Size: 845 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 69.74% 71.26% +1.51%
==========================================
Files 491 495 +4
Lines 103844 103926 +82
Branches 7498 11224 +3726
==========================================
+ Hits 72426 74061 +1635
+ Misses 31240 29865 -1375
+ Partials 178 0 -178
... and 140 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Anakaren!
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1371](#1371) [`ba5f33460`](ba5f334) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update attributes for expression widget button ### Patch Changes - [#1364](#1364) [`35651e097`](35651e0) Thanks [@Myranae](https://github.com/Myranae)! - Fix a bug in the exercise editor where the preview did not update after a change to the number of sides in polygon graphs - [#1373](#1373) [`961510673`](9615106) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Update the interactive graph builder with all currently migrated graph types ## @khanacademy/[email protected] ### Major Changes - [#1371](#1371) [`ba5f33460`](ba5f334) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update attributes for expression widget button ### Patch Changes - [#1373](#1373) [`961510673`](9615106) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph] Update the interactive graph builder with all currently migrated graph types - Updated dependencies \[[`35651e097`](35651e0), [`961510673`](9615106), [`ba5f33460`](ba5f334)]: - @khanacademy/[email protected]
Summary:
Issue Summary
Based on a Level Access audit, the keypad button in the expression widget
aria-checked
labelFix Summary
Clickable
component's role to be buttonaria-checked
Issue: LEMS-2082
Test plan:
Screenshots
Before
After