Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive ServerItemRenderer story #1369

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jun 21, 2024

Summary:

Super hacky, but a bad tool is better than no tool (maybe?)

Screen.Recording.2024-06-21.at.10.12.07.AM.mov

@handeyeco handeyeco self-assigned this Jun 21, 2024
@khan-actions-bot khan-actions-bot requested a review from a team June 21, 2024 15:08
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to packages/perseus/src/__stories__/server-item-renderer.stories.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (57dcf0a) and published it to npm. You
can install it using the tag PR1369.

Example:

yarn add @khanacademy/perseus@PR1369

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1369

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Size Change: 0 B

Total Size: 846 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-editor/dist/es/index.js 272 kB
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 407 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.95%. Comparing base (86f94e1) to head (57dcf0a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
+ Coverage   69.44%   70.95%   +1.50%     
==========================================
  Files         491      495       +4     
  Lines      103849   103924      +75     
  Branches     7450    10574    +3124     
==========================================
+ Hits        72123    73736    +1613     
+ Misses      31546    30188    -1358     
+ Partials      180        0     -180     

Impacted file tree graph

see 146 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f94e1...57dcf0a. Read the comment docs.

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super hacky, but a bad tool is better than no tool (maybe?)

Worse is better! 😂

My one question is whether this should be part of the yarn dev UI rather than Storybook, but we can always move it later (or reference the same component in both places)

@handeyeco
Copy link
Contributor Author

@benchristel I think long-term it would be better to add this to yarn dev. I have some questions about yarn dev's access to Perseus CSS though. I'm just going to cut this so we can start using it and we can iterate.

@handeyeco handeyeco merged commit 58ce867 into main Jun 24, 2024
19 of 22 checks passed
@handeyeco handeyeco deleted the interactive-item-renderer branch June 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants