-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive ServerItemRenderer story #1369
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (57dcf0a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1369 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1369 |
Size Change: 0 B Total Size: 846 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
+ Coverage 69.44% 70.95% +1.50%
==========================================
Files 491 495 +4
Lines 103849 103924 +75
Branches 7450 10574 +3124
==========================================
+ Hits 72123 73736 +1613
+ Misses 31546 30188 -1358
+ Partials 180 0 -180 see 146 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super hacky, but a bad tool is better than no tool (maybe?)
My one question is whether this should be part of the yarn dev
UI rather than Storybook, but we can always move it later (or reference the same component in both places)
@benchristel I think long-term it would be better to add this to |
Summary:
Super hacky, but a bad tool is better than no tool (maybe?)
Screen.Recording.2024-06-21.at.10.12.07.AM.mov