Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to legacy graph with unlimited sides polygon #1362

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

Myranae
Copy link
Contributor

@Myranae Myranae commented Jun 20, 2024

Summary:

Polygon graphs are almost fully migrated, but work on the unlimited sides feature is not slated to be completed until later. To allow us to move foward with Polygon QE and play testing, we are adding a fallback to the legacy graph for when numSides is set to unlimited. This can be easily removed once the unlimited sides feature is implemented.

Issue: LEMS-2105

Test plan:

  • Open local host storybook and navigate to the Interactive Graph Editor withMafs story
  • Confirm the Line Segment graph is using Mafs
  • Change the graph type to Polygon and confirm it is also using Mafs
  • Change number of sides to a new number. Confirm it is a Mafs graph. Change number of sides to unlimited. Confirm it is a legacy graph.
  • Change back to a specific number of sides and confirm it reverts to a Mafs graph. Change to another graph type and confirm it is also still a Mafs graph.
  • Confirm all checks pass.

@Myranae Myranae self-assigned this Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Size Change: +22 B (0%)

Total Size: 845 kB

Filename Size Change
packages/perseus/dist/es/index.js 407 kB +22 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-editor/dist/es/index.js 271 kB
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (fccb193) to head (e9e6827).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   69.76%   71.19%   +1.42%     
==========================================
  Files         489      493       +4     
  Lines      103371   103490     +119     
  Branches     7452    11214    +3762     
==========================================
+ Hits        72121    73683    +1562     
+ Misses      31072    29807    -1265     
+ Partials      178        0     -178     

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/widgets/interactive-graph.tsx 60.99% <100.00%> (+10.58%) ⬆️

... and 142 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c5064...e9e6827. Read the comment docs.

@Myranae Myranae marked this pull request as ready for review June 20, 2024 15:14
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/nervous-owls-retire.md, packages/perseus/src/widgets/interactive-graph.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team June 20, 2024 15:14
@Myranae Myranae requested review from benchristel, SonicScrewdriver and a team and removed request for a team June 20, 2024 15:14
Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Myranae Myranae merged commit 4bb2b87 into main Jun 20, 2024
24 of 30 checks passed
@Myranae Myranae deleted the tb/LEMS-2105/unlimited-sides-fallback branch June 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants