-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to legacy graph with unlimited sides polygon #1362
Conversation
Size Change: +22 B (0%) Total Size: 845 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
==========================================
+ Coverage 69.76% 71.19% +1.42%
==========================================
Files 489 493 +4
Lines 103371 103490 +119
Branches 7452 11214 +3762
==========================================
+ Hits 72121 73683 +1562
+ Misses 31072 29807 -1265
+ Partials 178 0 -178
... and 142 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Polygon graphs are almost fully migrated, but work on the unlimited sides feature is not slated to be completed until later. To allow us to move foward with Polygon QE and play testing, we are adding a fallback to the legacy graph for when
numSides
is set tounlimited
. This can be easily removed once the unlimited sides feature is implemented.Issue: LEMS-2105
Test plan: