Skip to content

Commit

Permalink
Knip 11: remove unused types (#1781)
Browse files Browse the repository at this point in the history
## Summary:
Remove unused types.

Part of my Knip experiment. Knip identified this as unused and I tried my best to verify that, but please double check!

Author: handeyeco

Reviewers: benchristel

Required Reviewers:

Approved By: benchristel

Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1781
  • Loading branch information
handeyeco authored Oct 22, 2024
1 parent 6729af8 commit f220366
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 38 deletions.
6 changes: 6 additions & 0 deletions .changeset/pretty-cherries-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/math-input": patch
"@khanacademy/perseus": patch
---

Remove unused types
2 changes: 0 additions & 2 deletions packages/math-input/src/components/input/mathquill-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,3 @@ declare module "mathquill" {
cursor?: Cursor;
}
}

export type MathQuillAriaStatisStringsMap = MathQuill.v3.AriaStaticStringsMap;
34 changes: 0 additions & 34 deletions packages/perseus/src/perseus-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ export type MultiItem = {
_multi: any;
};

export type PerseusArticle = ReadonlyArray<PerseusRenderer>;

export type Version = {
// The major part of the version
major: number;
Expand Down Expand Up @@ -1240,38 +1238,6 @@ export type PerseusTableWidgetOptions = {
answers: ReadonlyArray<ReadonlyArray<string>>;
};

export type DilationTransformation = {
type: "dilation";
center: Coord;
scale: number;
constraints: {
fixed: boolean;
};
};

export type ReflectionTransformation = {
type: "reflection";
line: [Coord, Coord];
constraints?: {
fixed: boolean;
};
};

export type RotationTransformation = {
type: "rotation";
angleDeg: number;
center: Coord;
constraints: {
fixed: boolean;
};
};

export type TranslationTransformation = {
type: "translation";
vector: Coord;
contraints: Empty;
};

export type PerseusInteractionWidgetOptions = {
// The definition of the graph
graph: PerseusInteractionGraph;
Expand Down
2 changes: 0 additions & 2 deletions packages/perseus/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,6 @@ export type ImageUploader = (
callback: (url: string) => unknown,
) => unknown;

export type WidgetSize = "normal" | "small" | "mini";

export type Path = ReadonlyArray<string>;

type StubTagEditorType = any; // from "./components/stub-tag-editor";
Expand Down

0 comments on commit f220366

Please sign in to comment.