Skip to content

Commit

Permalink
[Bugfix] - Adjust number formatting string to not fail (#1873)
Browse files Browse the repository at this point in the history
## Summary:
The formatting string for `srPointAtCoordinates` was missing an 's', which was causing a malformed string when extracted for use in Webapp.

Author: mark-fitzgerald

Reviewers: nishasy, #perseus

Required Reviewers:

Approved By: nishasy

Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1873
  • Loading branch information
mark-fitzgerald authored Nov 16, 2024
1 parent 7b18e94 commit def4630
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/sweet-sheep-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

[BUGFIX] - Adjust parameter name in srPointAtCoordinates to account for variable name conflict
2 changes: 1 addition & 1 deletion packages/perseus/src/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export const strings: {
graphKeyboardPrompt: "Press Shift + Enter to interact with the graph",
srPointAtCoordinates: {
context: "Screenreader-accessible description of a point on a graph",
message: "Point %(num) at %(x)s comma %(y)s",
message: "Point %(num)s at %(x)s comma %(y)s",
},
srInteractiveElements: "Interactive elements: %(elements)s",
srNoInteractiveElements: "No interactive elements",
Expand Down

0 comments on commit def4630

Please sign in to comment.