Revert "Fixing issue with Input Numbers that have a value of 0 (#1888)"

This reverts commit d0e7a03.
Khan · Nov 22, 2024 · 9a00cd7 · 9a00cd7
1 parent adad642
commit 9a00cd7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 39 deletions.
diff --git a/packages/perseus/src/__stories__/server-item-renderer.stories.tsx b/packages/perseus/src/__stories__/server-item-renderer.stories.tsx
@@ -5,7 +5,6 @@ import {ServerItemRendererWithDebugUI} from "../../../../testing/server-item-ren
 import {storybookDependenciesV2} from "../../../../testing/test-dependencies";
 import {
     itemWithInput,
-    itemWithInputNumber,
     itemWithLintingError,
     labelImageItem,
     itemWithImages,
@@ -28,10 +27,6 @@ export const NumericInputItem = (args: StoryArgs): React.ReactElement => {
     return <ServerItemRendererWithDebugUI item={itemWithInput} />;
 };
 
-export const InputNumberItem = (args: StoryArgs): React.ReactElement => {
-    return <ServerItemRendererWithDebugUI item={itemWithInputNumber} />;
-};
-
 export const LabelImageItem = (args: StoryArgs): React.ReactElement => {
     return <ServerItemRendererWithDebugUI item={labelImageItem} />;
 };

diff --git a/packages/perseus/src/__testdata__/server-item-renderer.testdata.ts b/packages/perseus/src/__testdata__/server-item-renderer.testdata.ts
@@ -7,7 +7,6 @@ import {
     type ExpressionWidget,
     type RadioWidget,
     type NumericInputWidget,
-    type InputNumberWidget,
 } from "../perseus-types";
 
 export const itemWithInput: PerseusItem = {
@@ -49,37 +48,6 @@ export const itemWithInput: PerseusItem = {
     answer: null,
 };
 
-export const itemWithInputNumber: PerseusItem = {
-    question: {
-        content:
-            "Enter the number $$-42$$ in the box: [[\u2603 input-number 1]]",
-        images: {},
-        widgets: {
-            "input-number 1": {
-                type: "input-number",
-                graded: true,
-                options: {
-                    static: false,
-                    value: 0,
-                    simplify: "required",
-                    maxError: 0.1,
-                    inexact: false,
-                    answerType: "number",
-                    size: "small",
-                },
-            } as InputNumberWidget,
-        },
-    },
-    hints: [
-        {content: "Hint #1", images: {}, widgets: {}},
-        {content: "Hint #2", images: {}, widgets: {}},
-        {content: "Hint #3", images: {}, widgets: {}},
-    ],
-    answerArea: null,
-    itemDataVersion: {major: 0, minor: 0},
-    answer: null,
-};
-
 export const itemWithMultipleNumericInputs: PerseusItem = {
     question: {
         content:

diff --git a/packages/perseus/src/widgets/numeric-input/numeric-input.tsx b/packages/perseus/src/widgets/numeric-input/numeric-input.tsx
@@ -345,10 +345,10 @@ const propsTransform = function (
 const propUpgrades = {
     /* c8 ignore next */
     "1": (initialProps: any): PerseusNumericInputWidgetOptions => {
-        // If the initialProps has simplify, it means we're upgrading from
+        // If the initialProps has a value, it means we're upgrading from
         // input-number to numeric-input. In this case, we need to upgrade
         // the widget options accordingly.
-        if (initialProps.simplify !== undefined) {
+        if (initialProps.value) {
             // If the answerType is not number or percent, we need to provide
             // the answer form for the numeric-input widget
             const provideAnswerForm =