Skip to content

Commit

Permalink
Move InteractiveGraphEditor to a directory (#1590)
Browse files Browse the repository at this point in the history
This is in preparation for splitting up the editor into multiple components,
which I think I'm going to have to do in order to type the `correct` prop
correctly (currently it has type `any`).

Issue: none

## Test plan:
CI should pass

Author: benchristel

Reviewers: nishasy, #perseus, jeremywiebe

Required Reviewers:

Approved By: nishasy

Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1590
  • Loading branch information
benchristel authored Sep 5, 2024
1 parent 435f3f6 commit 6c4e9e1
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 15 deletions.
6 changes: 6 additions & 0 deletions .changeset/tricky-forks-attend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/perseus": patch
"@khanacademy/perseus-editor": patch
---

Internal: Move InteractiveGraphEditor to its own directory
2 changes: 1 addition & 1 deletion packages/perseus-editor/src/all-editors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import IframeEditor from "./widgets/iframe-editor";
import ImageEditor from "./widgets/image-editor";
import InputNumberEditor from "./widgets/input-number-editor";
import InteractionEditor from "./widgets/interaction-editor";
import InteractiveGraphEditor from "./widgets/interactive-graph-editor";
import InteractiveGraphEditor from "./widgets/interactive-graph-editor/interactive-graph-editor";
import LabelImageEditor from "./widgets/label-image-editor";
import MatcherEditor from "./widgets/matcher-editor";
import MatrixEditor from "./widgets/matrix-editor";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import LockedFigureSelect from "./locked-figure-select";
import LockedFigureSettings from "./locked-figure-settings";

import type {LockedFigureSettingsMovementType} from "./locked-figure-settings-actions";
import type {Props as InteractiveGraphEditorProps} from "../../widgets/interactive-graph-editor";
import type {Props as InteractiveGraphEditorProps} from "../../widgets/interactive-graph-editor/interactive-graph-editor";
import type {LockedFigure, LockedFigureType} from "@khanacademy/perseus";

type Props = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from "react";

import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import InteractiveGraphEditorArgTypes from "./interactive-graph-editor.argtypes";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as React from "react";
import {testDependencies} from "../../../../../testing/test-dependencies";
import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import type {PerseusGraphType} from "@khanacademy/perseus";
import type {UserEvent} from "@testing-library/user-event";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {testDependencies} from "../../../../../testing/test-dependencies";
import {waitForInitialGraphieRender} from "../../../../../testing/wait";
import {flags} from "../../__stories__/flags-for-api-options";
import {getDefaultFigureForType} from "../../components/util";
import InteractiveGraphEditor from "../interactive-graph-editor";
import InteractiveGraphEditor from "../interactive-graph-editor/interactive-graph-editor";

import type {PerseusGraphType} from "@khanacademy/perseus";
import type {PropsFor} from "@khanacademy/wonder-blocks-core";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ import {StyleSheet} from "aphrodite";
import * as React from "react";
import _ from "underscore";

import LabeledRow from "../components/graph-locked-figures/labeled-row";
import LockedFiguresSection from "../components/graph-locked-figures/locked-figures-section";
import GraphPointsCountSelector from "../components/graph-points-count-selector";
import GraphTypeSelector from "../components/graph-type-selector";
import {InteractiveGraphCorrectAnswer} from "../components/interactive-graph-correct-answer";
import InteractiveGraphSettings from "../components/interactive-graph-settings";
import SegmentCountSelector from "../components/segment-count-selector";
import StartCoordsSettings from "../components/start-coords-settings";
import {shouldShowStartCoordsUI} from "../components/util";
import {parsePointCount} from "../util/points";
import LabeledRow from "../../components/graph-locked-figures/labeled-row";
import LockedFiguresSection from "../../components/graph-locked-figures/locked-figures-section";
import GraphPointsCountSelector from "../../components/graph-points-count-selector";
import GraphTypeSelector from "../../components/graph-type-selector";
import {InteractiveGraphCorrectAnswer} from "../../components/interactive-graph-correct-answer";
import InteractiveGraphSettings from "../../components/interactive-graph-settings";
import SegmentCountSelector from "../../components/segment-count-selector";
import StartCoordsSettings from "../../components/start-coords-settings";
import {shouldShowStartCoordsUI} from "../../components/util";
import {parsePointCount} from "../../util/points";

import type {
PerseusImageBackground,
Expand Down

0 comments on commit 6c4e9e1

Please sign in to comment.