Skip to content

Commit

Permalink
The final 'Upload Coverage' step doesn't need local source or node_mo…
Browse files Browse the repository at this point in the history
…dules (#1571)

## Summary:

I noticed this last step in our CI runs takes a bit of time for what amounts to downloading 2 files and then uploading them to Codecov. 

This action uses only other Github shared actions and so it doesn't need to checkout the source or install node_modules. This should speed up this last step in our CI runs somewhat. 

Issue: "none"

## Test plan:

I'll need to land this and then watch the next PR that runs this action.

Author: jeremywiebe

Reviewers: handeyeco, benchristel, SonicScrewdriver, Myranae, nicolecomputer, catandthemachines

Required Reviewers:

Approved By: handeyeco

Checks: ✅ gerald, ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️  Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1571
  • Loading branch information
jeremywiebe authored Aug 29, 2024
1 parent 50c1b19 commit 5415164
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,6 @@ jobs:
node-version: [20.x]
needs: [cypress, coverage]
steps:
- uses: actions/checkout@v4

- name: Install & cache node_modules
uses: ./.github/actions/shared-node-cache
with:
node-version: ${{ matrix.node-version }}
ssh-private-key: ${{ secrets.KHAN_ACTIONS_BOT_SSH_PRIVATE_KEY }}

- name: Download Jest Coverage
uses: actions/download-artifact@v4
with:
Expand Down

0 comments on commit 5415164

Please sign in to comment.