Skip to content

Commit

Permalink
Remove isMobile from Dependencies (#1789)
Browse files Browse the repository at this point in the history
## Summary:
Remove isMobile from Dependencies since it's now on APIOptions

Author: handeyeco

Reviewers: mark-fitzgerald, jeremywiebe

Required Reviewers:

Approved By: mark-fitzgerald

Checks: ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1789
  • Loading branch information
handeyeco authored Oct 23, 2024
1 parent c6ee266 commit 0587dc0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/smart-phones-rush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Remove isMobile from Dependencies since it's now on APIOptions
1 change: 0 additions & 1 deletion packages/perseus/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ export type PerseusDependencies = {
// RequestInfo
isDevServer: boolean;
kaLocale: string;
isMobile: boolean;
};

/**
Expand Down
1 change: 0 additions & 1 deletion testing/test-dependencies.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export const testDependencies: PerseusDependencies = {

isDevServer: false,
kaLocale: "en",
isMobile: false,

Log: LogForTesting,
};
Expand Down

0 comments on commit 0587dc0

Please sign in to comment.