Commits on Sep 10, 2021

1. Make README logo work in dark mode …

   Dark mode is, they say, the new thing, and the logo doesn't work super
   well with it, because it's black on dark grey.  This is surprisingly
   hard to fix.  There are a few options:
   - make the logo colored; sorry, but I like black
   - add a white border to the logo; this is what Apollo does but I
     think it's pretty ugly in dark mode
   - add svg with media queries; this works well but only if the github
     dark mode setting matches the browser(/OS) dark mode setting, since
     that's what the media queries look at
   I opted for option 3.  This required converting the text in the SVG to
   paths, since it really matters that you have the exact same font.  (I
   tested on Android Firefox, which empirically doesn't have the same fonts
   I have on desktop.)
   
   Fixes #17.
   
   Issue: #17
   
   Test plan:
   tested that it looks good on both mobile firefox in dark mode, and
   desktop firefox+chrome in light mode.
   
   Reviewers: dbraley, kevinb, kevindangoor, marksandstrom

   

   benjaminjkraft committed Sep 10, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for ecf2d4b
   • Browse repository at this point

   Copy the full SHA

   ecf2d4b View commit details

   Browse the repository at this point in the history