Add support for interfaces, part 3: automatically add __typename #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjkraft
changed the title
benjaminjkraft
force-pushed
the
benkraft.interfaces-3
branch
from
807a91a
to
1771758
Compare
benjaminjkraft
force-pushed
the
benkraft.interfaces-2
branch
from
b5469dc
to
cc1942e
Compare
benjaminjkraft
force-pushed
the
benkraft.interfaces-3
branch
from
1771758
to
1821951
Compare
benjaminjkraft
force-pushed
the
benkraft.interfaces-2
branch
from
624c176
to
f8d359c
Compare
benjaminjkraft
force-pushed
the
benkraft.interfaces-3
branch
from
1821951
to
ef831b4
Compare
dnerdy
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
This looks great! It's nice to have the genqlient automatically request __typename.
One very minor issue I can foresee is if an object already has a field named typename. Then the names would conflict. Perhaps this means the __typename field will need to be made configurable at some point.
|
Ah, good point. I'll just make a separate issue for that (edit: #60); there are some other potential conflicts. |
benjaminjkraft
force-pushed
the
benkraft.interfaces-3
branch
from
ef831b4
to
3f3c64d
Compare
benjaminjkraft
force-pushed
the
benkraft.interfaces-2
branch
from
f5e4166
to
9ffbc9f
Compare
In #52, I added support for interface types, but with the simplifying restriction (among others) that the user must request the field `__typename`. In this commit, I remove this restriction. The basic idea is simple: we preprocess the query to add `__typename`. The implementation isn't much more complicated! Although it required some new wiring in a few places. Issue: #8 Test plan: make tesc Reviewers: marksandstrom, adam, miguel
benjaminjkraft
force-pushed
the
benkraft.interfaces-3
branch
from
3f3c64d
to
c37edb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #52, I added support for interface types, but with the simplifying
restriction (among others) that the user must request the field
__typename. In this commit, I remove this restriction.The basic idea is simple: we preprocess the query to add
__typename.The implementation isn't much more complicated! Although it required
some new wiring in a few places.
Issue: #8
Test plan:
make check