Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed "for" directive documentation #235

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fixed "for" directive documentation #235

merged 1 commit into from
Nov 17, 2022

Conversation

bafko
Copy link
Contributor

@bafko bafko commented Nov 17, 2022

This PR is addressing the behavior described in #151.
The former version of for directive example usage ended in:

genqlient.graphql:<line>: for is only applicable to operations and arguments

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@StevenACoffman
Copy link
Member

Thanks!

@benjaminjkraft
Copy link
Collaborator

Oh, great catch, thanks.

@StevenACoffman StevenACoffman merged commit 00f2760 into Khan:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman approved these changes

@benjaminjkraft benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft is a code owner

@csilvers csilvers Awaiting requested review from csilvers csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bafko @StevenACoffman @benjaminjkraft