Bump golangci-lint and (max) Go versions #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint is failing with some inscrutable panic (on a commit with no code changes). Let's try bumping the version in case they fixed it. While I was at it, I added Go 1.19 to the list of versions we test, since it's out now (fixes #216). Test plan: make lint
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
|
Turns out the newest golangci-lint also uses Go 1.19, and turns out that means we need to update gofmt which does some new doc-comment formatting, and then I want to tweak some of our formatting while I'm at it. Will return to this later. |
csilvers
approved these changes
Aug 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint is failing with some inscrutable panic (on a commit with no code
changes). Let's try bumping the version in case they fixed it.
Additionally, the new version's github action uses Go 1.19, which means
it pulls in gofmt updates to match the new doc-comment formatting rules.
So I added Go 1.19 to our list of versions to test (fixes #216)
and updated some of our doc-comments to format better in the
new world (mostly using the new link syntax).
Test plan: make lint
I have: