Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tested Go versions (and deps) #179

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Update tested Go versions (and deps) #179

merged 2 commits into from
Mar 22, 2022

Conversation

benjaminjkraft
Copy link
Collaborator

@benjaminjkraft benjaminjkraft commented Mar 22, 2022

Go 1.18 is out! So we should run tests on it.

Additionally, gqlgen had some issues with it (see 99designs/gqlgen#1961
and golang/go#45584) so I updated that too, which updated some other
things.

Finally, latest gqlgen requires 1.16+, and it's time for us to do the
same anyway, so we can use embed and other newer goodies. So I
dropped running tests for 1.14 and 1.15, and bumped the module language
version.

Test plan: make check

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you've signed the khan academy CLA? :-P

Change looks good to me. You may want to add the special .gitattributes thing that tells github to hide diffs for go.sum.

Go 1.18 is out! So we should run tests on it.

Additionally, gqlgen had some issues with it (see 99designs/gqlgen#1961
and golang/go#45584) so I updated that too, which updated some other
things.

Finally, latest gqlgen requires 1.16+, and it's time for us to do the
same anyway, so we can use `embed` and other newer goodies.  So I
dropped running tests for 1.14 and 1.15, and bumped the module language
version.

Test plan: make check
@benjaminjkraft benjaminjkraft changed the title Update tested Go version and deps Update tested Go versions (and deps) Mar 22, 2022
@benjaminjkraft
Copy link
Collaborator Author

Are you sure you've signed the khan academy CLA? :-P

I did! I realized while writing the checklist that now I actually ought to!

Change looks good to me. You may want to add the special .gitattributes thing that tells github to hide diffs for go.sum.

Ah, good idea. I marked it generated so you can still expand the diff.

Also note I added to this removal of 1.14 and 1.15 (PR message now updated).

@csilvers
Copy link
Member

Also note I added to this removal of 1.14 and 1.15 (PR message now updated).

Yeah, I assume that's a gqlgen limitation?

@benjaminjkraft
Copy link
Collaborator Author

Yeah. Makes sense for us too, so we can use embed (PR to follow).

@benjaminjkraft benjaminjkraft merged commit 13094c3 into main Mar 22, 2022
@benjaminjkraft benjaminjkraft deleted the benkraft.go118 branch March 22, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants