Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added splash screen for android #97

Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat: added splash screen for android #97

merged 2 commits into from
Apr 28, 2022

Conversation

amitojsingh
Copy link
Collaborator

@amitojsingh amitojsingh commented Feb 16, 2022

image (1)
image

This is how Splash Screen will look like.

@inderpreetsingh inderpreetsingh self-requested a review April 20, 2022 17:35
Copy link
Contributor

@inderpreetsingh inderpreetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veerji, please add a gif showing the splash screen in the description of PR.

android/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
startActivity(intent);
finish();
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at the end of the file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @inderpreetsingh Veer ji

android/app/src/main/res/drawable/backgroud_splash.xml Outdated Show resolved Hide resolved
@inderpreetsingh inderpreetsingh self-requested a review April 28, 2022 14:16
@amitojsingh amitojsingh merged commit 7b3f782 into dev Apr 28, 2022
@amitojsingh amitojsingh deleted the fix-splashScreen branch July 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants