fix: firebase push notification #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inderpreetsingh
requested changes
Apr 20, 2022
android/app/src/main/java/com/WahegurooNetwork/SundarGutka/MainActivity.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/com/WahegurooNetwork/SundarGutka/MainApplication.java
Outdated
Show resolved
Hide resolved
|
@amitojsingh veerji, you probably missed some of the requested changes above. Also, this branch started getting conflicts. Please resolve them as well. |
…a-react into feat-add-firebase-messaging
|
@inderpreetsingh veer ji I think I have fixed all could you please check again. |
veerji please try clicking |
|
Apologies, I missed that. |
No worries veerji. Great job 🙌 Let's resolve the last comment and get this one merged. |
…a-react into feat-add-firebase-messaging
inderpreetsingh
approved these changes
May 5, 2022
|
This one can be merged @amitojsingh veerji |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the firebase push notification feature which was outdated earlier