Link argon2 using pkg-config #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks. Btw I used libffi instead of c stubs because I was lazy to setup the build system, but I have nothing against it |
|
I don't think I'll have time to convert these bindings to use Cstubs these weeks, but can take a stab at it sometime. |
|
Some time later, I wonder whether a release could be done with this change in? :) Thanks a lot. |
|
I'll have a look at that |
|
Dear @Khady, any news on this 3 months later? Would cutting a new release be possible? |
|
trying to publish in ocaml/opam-repository#24314 |
|
I don't really have time to investigate this build issue. It is visible in the CI too https://github.com/Khady/ocaml-argon2/actions/runs/7752494989/job/21142095865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change argon2 will be linked using pkg-config, fixing #6. Configurator docs, example from docs. I did it slightly differently to the Configurator pkg-config example and used
(flags ...)instead of(c_library_flags ...)stanza since these bindings are built directly with Ctypes.Foreign and libffi instead of C stubs.