RootBuilder performance improvements #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change validGameRootFiles in rootbuilder_paths.py, so it filters out files and folders that match exclusions while listing them, instead of after getting all the files. This significantly improves performance in many cases.
Use os.walk, which handles the check for whether a path is a directory internally and more efficiently that the previous method. Also allows walking bottom-up, removing the need for recursion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes to improve the performance of RootBuilders Sync/Clear operations. Some more details of the changes in the commit messages.
I have a sizable mod list, and also have the Creation Kit installed (which puts a large number of files in "Skyrim Special Edition\Data\Source\Scripts"), and RootBuilder was taking well over 10 seconds to perform the Clear action, despite the Data directory being excluded. After these updates, it now takes about 0.1 seconds.
Another thing I noticed was creating the cache after deleting it would freeze the gui for a second. It looks like this is because it's trying to load a json file that doesn't exist through common_utilities.py, which will retry for 1 second. I assume there's some reason for that, but maybe it could be removed for this case?