Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "no copy" option for reinstaller which use a text file (
MO2Plugins/Data/Reinstaller/installers.txt
) that list the installers instead of copying the files to the plugin data folder.I believe this could be useful for users as myself that prefer to keep all the downloaded files (for Wabbajack purposes for example).
This is implemented by adding
no_copy
setting to the plugin. If set to true (default behavior) the plugin keeps its original behavior. If set to false, the plugin uses a subclass ofReinstaller
andReinstallerPaths
that implements the use of the text files.The drawback of this implementation is that because the plugin is already loaded when the setting is changed, MO2 must be restarted to apply the new behavior. However, this is standard practice for MO2 plugins, so it shouldn't pose a significant issue.
Marking this PR as a draft for now because I have not yet tested the behavior of the quick install and quick delete menus. So far, I have only implemented and tested the full reinstaller menu.
Also, I left the changes made by my linter, Ruff, to the files I touched, but I can remove them if necessary.