Updated storybook, split main component into more meaningful components #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rating-average/RatingAverage.tsx
Outdated
| const RatingAverage: FC<IRatingAverageProp> = (props) => { | ||
| const { | ||
| ratings, | ||
| customAverageFn, |
There was a problem hiding this comment.
can't we have customAverageFn = getWeightedAverage and remove computeAverage?
README.md
Outdated
| averageRatingPrecision={2} | ||
| ratingAverageIconProps={{ | ||
| fillColor: 'green', | ||
| bgColor: 'red' |
There was a problem hiding this comment.
Is the code part correctly formatted?
arunghosh-kv
approved these changes
Nov 15, 2023
src/rating-summary/RatingSummary.tsx
Outdated
| if (getElementStyle) return getElementStyle(ratingId); | ||
| return {}; | ||
| const getRatingRanks = (): RatingRanks => { | ||
| if (Object.keys(ratingRanks).length) return { ...ratingRanks }; |
There was a problem hiding this comment.
this spread has no here since this is used as prop
src/rating-summary/RatingSummary.tsx
Outdated
| )} | ||
| <div | ||
| className={classes.ratingsWrapper} | ||
| style={{ ...styles[GenericElements.SummaryContainer] }} |
src/rating-average/RatingAverage.tsx
Outdated
| className={classes.starImage} | ||
| style={{ ...styles[GenericElements.AverageStarIcon] }} | ||
| > | ||
| <PartiallyFilledStar |
There was a problem hiding this comment.
Rename the component to match with the functionality
…d operator, updated storybook, renamed a component
bilta-keyvalue
approved these changes
Nov 17, 2023
anjuca154
approved these changes
Nov 17, 2023
bilta-keyvalue
pushed a commit
that referenced
this pull request
Nov 23, 2023
* added search keyvwords for npm * Updated storybook, split main component into more meaningful components (#9) * Updated storybook, split main jsx into more meaningful components * Added average rating section * Added more style customisation options * style corrections and more style customisation options added * Added support for string rating-ids, refactored code * updated testcases * Updated readMe and storybook * Rating rank logic adjusted * updated storybook * Added support to customize un-filled bar in the summary chart section * made summary labels take width of longest item, making it into table style * updated readMe and corrected indentation. * updating storybook template * update .gitignore * PR comment fixes - Optimize code by removing unnecessary object spread operator, updated storybook, renamed a component * PR comment fixes - renamed some props, updated readMe with more detailed information * updated code-sandbox link with the one created in keyvalue workspace * fixed issue: inner progress bar overflowing the outer container * updated email in code_of_conduct.md file * Added pull-request and style templates to the repo * update release version in package.json * fix:make description of prop ratingRanks simpler * revert version bump --------- Co-authored-by: GokulSNath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.