Use IsValidJsonString, inplace of DetectIsJson - more reliable. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added |
KevinJump
added a commit
that referenced
this pull request
Jan 23, 2024
* Use IsValidJsonString, inplace of DetectIsJson - more reliable. * Move to a TryParseValidJsonString, to reduce the number of times we parse the json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #566 from @paulwoodland . stop using
DetectIsJsonbecause it can give you false positives.instead, we are using
IsValidJsonin all places (outside of the actual extensions).this can mean in some cases we end up parsing the json twice (once to detect it, and then later on when we actuall use it.
i wonder if we shoud really have a try parse ??